MySQL weird update error

[Shem]

I have a simple, plain UPDATE statement that keeps throwing up an error. I've been toying with this for hours:

$query ="UPDATE users SET blogaddress='www.that.blogspot.com', blogaddress2='something', WHERE id = 1 ";

and the error:

Cannot run this query: You have an error in your SQL syntax. Check the
manual that corresponds to your MySQL server version for the right
syntax to use near 'WHERE id = 1' at line 1

[Shem]

I also tried WHERE id = '1'


and I also tried

$query ="UPDATE users SET blogaddress='www.that.blogspot.com', blogaddress2='something', WHERE users.id = '1' ";


and they are all throwing up similar errors .

[guido2004]

delete the comma after 'something'

[Shem]

OK, that was it. Thanks. Somehow I had kept a comma after the last table alteration in previous code , which must be a bad habit. I know this because I checked previous UPDATE code I had written years back.

Maybe it was an earlier version of MySQL or I was just lucky. Thanks for the heads up. I love this forum.

[guido2004]

You're welcome

[Cups]

$a = array( 'this' => 1,'that' => 2,'the other'=>3, ) ;  
// in php a trailing comma is allowed in an array declaration ... see after "3"

// simple query builder based on that array

$qry = 'update table set ' ;

foreach( $a as $k=>$v ){
$qry .= $k . ' = ' . $v . ',' ;
}

$qry = rtrim( $qry , "," );
$qry .= ' where id = 1 ' ;

echo $qry ;

// gives :
// update table set this = 1,that = 2,the other = 3 where id = 1 

If you were using some kind of query builder, I would guess you lost a rtrim() somewhere along the line rather than mysql changing how it deals with the rather strict sql statements.

[r937]

if you had been using the leading comma coding convention, it would have been more obvious

trailing comma convention --

UPDATE users 
   SET blogaddress = 'www.that.blogspot.com', 
       blogaddress2 = 'something', 
 WHERE id = 1

leading comma convention --

UPDATE users 
   SET blogaddress = 'www.that.blogspot.com'
     , blogaddress2 = 'something'
     , 
 WHERE id = 1

see? more obvious

of course, this assumes you also indent your code

(which i just cannot understand why some people don't)

[guido2004]

if you had been using the leading comma coding convention, it would have been more obvious

I was thinking about linking to that post of yours you once mentioned, but I forgot how it was called, so I couldn't find the post, and decided to let it be