help with insert news script

[Roadie]

i have this script:

<?
//connect to database
$link= mysql_connect ("localhost", "root", "godzilla");
mysql_select_db ("CSI");

//build query
$query= "INSERT INTO tbl_articles (issue, authorID, catID, subcat, title, subhead1, subhead2, specs, body) 
VALUES ('$issue', $authorID, $catID, '$subcat', '$title', '$subhead1', '$subhead2', '$specs', '$body')";

$result = mysql_query ($query);

if (!$result) {
        print (mysql_error());
}else{
        print ("data added succesfully");
        }


mysql_close ($link);
?>

and its giving me this error:

You have an error in your SQL syntax near ' , '', '', '', '', '', '')' at line 2


I cant figure out what it is, can anyone help me out?

[Technosailor]

Try rewriting your query like this:

INSERT INTO tbl_articles SET
issue    = '$issue',
authorID = '$authorID',
catID    = '$catID',
subcat   = '$subcat',
title    = '$title',
subhead1 = '$subhead1',
subhead2 = '$subhead2',
specs    = '$specs',
body     = '$body'; 

Structure (visually) isn't so important although helpful. The important part is to write the query as I have written it.(EDIT***That sounds pretty cocky doesn't it? Sorry) The "values" method works but is more difficult to look at and debug. The way I wrote it I know has good syntax, so if you get errors, check your field names or otherwise.

Have fun.

Sketch

[gcarlyle]

In your line with

VALUES ('$issue', $authorID, $catID, '$subcat', '$title', '$subhead1', '$subhead2', '$specs', '$body')"; 

$authorID and $catID needs to have the single quote ' around them.

I think that is your problem.

Hope it helps
Jennifer

[Sarah]

Jennifer,

You don't need to single quote around number values i.e. if his ID columns are only numbers then he doesn't need to single quote them...

sorry really bad english there

[gcarlyle]

That's greate. I didn't know if I was right but I had to take a stab at it any way.

Just learned something so it was worth it.

[Roadie]

Sketch: thanks, that lokos great. I didint know you could it like that. I need to use addslashes with the body, so would i do it like :

body = addslashes('$body');

?

Jenn, thank you for your help, but as Sarah said you don't have to (and shouldn't) put single quotes around numeric values. I'm a PHP newbie too, and they say the best way to learn is to help someone else so keep at it.

[Technosailor]

ummm....

$body = addslashes($body) 

Make sure you put that $ sign on the front.

Sketch

[Roadie]

I'm sorry i didnt phrase that well...I would use addslashes before the insert statement, not when i am doing

body = '$body';

inside the insert stament, right?

[Technosailor]

I think it could be done either way, but just to be safe, do it prior to running the insert query.

Sketch

[DR_LaRRY_PEpPeR]

remember, you shouldn't use addslashes() if magic_quotes_gpc is on. you'll add too many slashes! i hate this, one of the things that really complicates things for beginners. i hate magic_quotes. see the section magic_quotes, addslashes(), and stripslashes() in my PHP and MySQL coding tips thread for more info.

just trying to help you get your text in the database correctly.

[Roadie]

yes, thats right, i did read that thread actually. Im not sure if magic quotes is on though, how do i check to see if it is, and how do i turn it off?

actually, lemme take a gander at that thread again...

[Roadie]

ok i see i am supposed to make a change to the php.ini file, but i cant find where it is located...I am using mac os x, does anyone know where it is?