Coding quality on shopping cart

[blain]

Can anyone improve on the quality of this code?

<table class="cart" cellspacing="0" summary="Shopping Basket">
<tr class="cart_headings">
    <th class="cart_item">Item</th>
    <th class="cart_price">Price</th>
    <th class="cart_quantity">Quantity</th>
    <th class="cart_total">Total</th>
</tr>
<tr class="product">
    <td class="product_name">Flat Screen Compact Computer Station </td>
        <td class="product_price">&pound;302.85</td>
    <td class="product_quantity"><input class="cart_input_quantity" type="text" name="updq_3" value="3"></td>
    <td class="product_total_price">&pound;908.55</td>
</tr>
<tr class="product">
    <td class="product_name">test </td>
    <td class="product_price">&pound;10.00</td>
    <td class="product_quantity"><input class="cart_input_quantity" type="text" name="updq_5" value="1"></td>
        <td class="product_total_price">&pound;10.00</td>
</tr>
<tr>
    <td colspan="3" class="right_align"><input type="submit" class="cart_update_quantity" name="a" value="Update Quantities"></td>
    <td>&nbsp;</tr>
</tr>
<tr>
    <th colspan="3" class="cart_subtotal">Subtotal:</th>
    <td>&pound;918.55</td>
</tr>
<tr>
    <th colspan="3" class="cart_vat">VAT:</th>
    <td>&pound;160.75</td>
</tr>
<tr>
    <th colspan="3" class="cart_grandtotal">Total:</th>
    <td>&pound;1079.30</td>
</tr>
</table>

[dgroves]

I can help you, but only if you put in a screenshot of the final result so I can visualize what we are working towards. Do that and I will give you some plentiful advice and help

[JREAM]

That is actually pretty clean code for tables,
and it is Tabular Data, You don't really have to change it to Div's if you were considering it. (IMO)

If you wanted it to look cleaner you could remove a lot of classes and compile them into CSS.

<tr class="cart_headings">
<th>Item</th>
<th>Price</th>
<th>Quantity</th>
<th>Total</th>
</tr>

CSS for Cart Heading (If they are all the same)

.cart_headings {
font: 14px arial, sans-serif;
font-weight: bold;
}

[dgroves]

Thinking about it now, I suppose that you are right really, their is not much that can really be done.

[r937]

i agree, there is nothing wrong with using html TABLE tags if you have tabular data

the one-class-per-column-type definitely has to go, though

[dgroves]

the one-class-per-column-type definitely has to go, though

Absolutely

[blain]

The reason I added a class to each column is to increase semantics, it also means that I can easily style parts of the shopping cart, surely that can't be a bad thing?

When I spoke of improving the code, I was mainly wanting to address any accessibility or usability issues.

[r937]

i'll let others comment on whether styling individual elements via classes is a good thing, but as far as i know it does not increase semantics

if you wanted to address accessibility or usability issues, you might have mentioned this in your original post

i thought you want improved "quality of code"

[blain]

Sorry if I wasn't clear Rudy.

I always consider that code quality/accessibility/usability all go hand in hand.