Preloading thumbs asking for advice and improvement

[whisher]

Hi.
This is my code:

function preloadImg(url) {
        var temp=new Image();
        temp.src=url;
    }
function imgs(){
        var el= document.getElementsByTagName('img');
        for(var i=0,len=el.length;i<len;i++){
            url= el.item(i).src.replace('thumbs', 'uploaded');
            preloadImg(url);
            alert(url);
            addEvent(el.item(i),'click',popunder);
        }
    } 

Any other better ways will be gracefully appreciated

Bye.

[Logic Ali]

function preloadImg(url) {
		var temp=new Image();
		temp.src=url;
	}

preloadImg is called in a loop, meaning that temp is repeatedly created and destroyed before the download takes place.

[whisher]

Thanks for the point
New version:

function preloadImg(urls) {
    var tmp=[];
    for(var i=0,len=urls.length;i<len;i++){
        tmp[i]=new Image();
        tmp[i].src=urls[i];
    }
}
function imgs(){
        var urls= [];
        var el= document.getElementsByTagName('img');
        for(var i=0,len=el.length;i<len;i++){
            url= el.item(i).src.replace('thumbs', 'uploaded');
            urls[i]=url;
            addEvent(el.item(i),'click',popunder);
        }
        preloadImg(urls);
    } 

Bye.

[Logic Ali]

function preloadImg(urls) {
	var tmp=[];
	for(var i=0,len=urls.length;i<len;i++){
		tmp[i]=new Image();
		tmp[i].src=urls[i];
	}
}

This doesn't really change anything. The function initialises a series of downloads, then immediately destroys the containing objects before the downloads can complete.

[whisher]

Sorry, but what's your idea about a preload function ?

Bye.

[whisher]

In short:

function Thumb(){
     var imgs= {};
    function preloadImg(){
        var el= document.getElementsByTagName('img');
        for(var i=0,len=el.length;i<len;i++){
            var tmp= el.item(i);
            url= tmp.src.replace('thumbs', 'uploaded');
            imgs[tmp.id]= new Image();
            imgs[tmp.id].src=url;
            imgs[tmp.id].title=tmp.title;
            imgs[tmp.id].alt=tmp.alt;
            addEvent(tmp,'click',popunder);
        }
    }
    function box(largeImg){
        var bodyEl= document.getElementsByTagName('body')[0];
        bodyEl.appendChild(largeImg);
    }
    function popunder(e){
        cancelClick(e);
        var imgTarget= getTarget(e);
        box(imgs[imgTarget.id]);
    }
    function init(){
        if(!document.getElementById || !document.getElementsByTagName || !document.createTextNode){return;}
        preloadImg();
    }
    init();
}
addEvent(window,'load',Thumb); 

My best