EventListener help

[Golgotha]

Testing the below code in Firefox does not work?
Firebug says, "BtnExternalFeeds has no properties"

Any ideas?

var setExternalFeeds = 
{ 
    init: function()
    {       
        var BtnExternalFeeds = document.getElementById("BtnExternalFeeds");
        if (typeof BtnExternalFeeds.addEventListener != "undefined")
        {
            alert("test");
            BtnExternalFeeds.addEventListener("click", setExternalFeeds.clickListener, false);
        }     
    },
      
    clickListener: function()
    {
        alert(Feeds.length);
    }
};
// set the page load handler
if(typeof window.addEventListener != 'undefined')
{
    // not IE
    window.addEventListener('load', setExternalFeeds.init(), false);
} else {
    // IE
    window.attachEvent('onload', setExternalFeeds.init());
}

[Raffles]

You don't need to execute the function within your addEventListener. Instead, you have to provide a function reference:

var setExternalFeeds = 
{ 
    init: function()
    {       
        var BtnExternalFeeds = document.getElementById("BtnExternalFeeds");
        if (window.addEventListener)
        {
            alert("test");
            BtnExternalFeeds.addEventListener("click", setExternalFeeds.clickListener, false);
        }     
    },
 
    clickListener: function()
    {
        alert(Feeds.length);
    }
};
// set the page load handler
if(window.addEventListener)
{
    // not IE
    window.addEventListener('load', setExternalFeeds.init, false);
} else {
    // IE
    window.attachEvent('onload', setExternalFeeds.init);
}

If you still get an error, check that you have the right ID for BtnExternalFeeds.

[Golgotha]

see below...

[Golgotha]

It now accepts the eventListener, but when clicked it throws the error and says, "btnExternalFeeds is not defined"...

error is on the line with btnExternalFeeds.value = "click me";

doesn't window.onload happen only after the entire page is loaded?

why is it then not defined?

var setExternalFeeds = 
{ 
    init: function()
    {       
        var feeds = document.getElementById("externalFeeds").getElementsByTagName("div");
        var btnExternalFeeds = document.getElementById("BtnExternalFeeds");
 
 
        if (typeof btnExternalFeeds.addEventListener != "undefined")
        {
            btnExternalFeeds.addEventListener("click", setExternalFeeds.clickListener, false);
        }     
    },
 
    clickListener: function()
    {
        //alert("test");
        btnExternalFeeds.value = "click me";
    }
};
// set the page load handler
if(typeof window.addEventListener != 'undefined')
{
    // not IE
    window.addEventListener('load', setExternalFeeds.init, false);
} else {
    // IE
    window.attachEvent('onload', setExternalFeeds.init);
}

[Golgotha]

anyone?

[taliesinnz]

change

btnExternalFeeds.value =  "click me";

to

document.getElementById("BtnExternalFeeds").value =  "click me";

[taliesinnz]

or

var setExternalFeeds = 
{
   btnExternalFeeds : null,
   init: function()    
   {
        var feeds = document.getElementById("externalFeeds").getElementsByTagName("div");
        this.btnExternalFeeds = document.getElementById("BtnExternalFeeds");
        if (typeof this.btnExternalFeeds.addEventListener != "undefined")
        {            
                 this.btnExternalFeeds.addEventListener("click", setExternalFeeds.clickListener, false);
        }
    }, 
 
    clickListener: function()    
    {        
          //alert("test");
         this.btnExternalFeeds.value = "click me";
    }
 
};// set the page load handler
 
if(typeof window.addEventListener != 'undefined')
{    // not IE    
           window.addEventListener('load', setExternalFeeds.init, false);
}
 else 
{    // IE    
       window.attachEvent('onload', setExternalFeeds.init);
}