Command Pattern MVC

[blueyon]

I have noticed a lot of examples in the forum are not using classes for every action rather than using methods.

Instead of

class product {
function view();
fuction insert();
function update();
}

They are using

class ProductInsert {
function execute();
}

A lot of the frameworks use the first example when implementing MVC.

My Questions:
1. Which is the correct way?
2. What are the advantages disadvantages?

[mihd]

i use the first method, otherwise i would end up with hundreds of classes

[wysiwyg]

I like having one controller for every resource, like Konstrukt handles it. One controller have a GET()-method and a POST()-method to handle get and post requests. And in the case of insert-/update-forms, you just let the update-controller inherit from the insert-controller, and use the same common functionality.

[blueyon]

I've found the second method is better to use for implementing certain patterns like action filter and composite pattern.

[php_daemon]

The second method is more formalized, thus possible to implement with different design patterns, easier to maintain and reuse. Besides, using methods, such an object tends to easily grow into having too many responsibilitites.

[Dr Livingston]

Umm...

I tend to have the one Controller with show (default), insert, et al in that Controller, and then have those responsibilities, etc in other separate classes which keeps the Controller in question a bit thin.

But I see your point, as in a lot of examples that demonstrate the numerous frameworks out there, you do see the responsibilities, ie Models, Views etc are placed in the class method it's self.

That is a bad practice in my opinion, as those responsibilities themselves should be encapsulated, and not exposed to the open. But that's life I suppose

From my point of view, that's not to say that it's a bad design decision to retain multiple methods in the same Controller, if they are related, ie a QProducts_Controller for example?

[Aso]

I use the first example because my views arent built in the controller so most of my controllers look like $view->render()

the second example is more re-usable and can co-operate better with other design patterns. But for now this is just too much work for me

[kyberfabrikken]

Between the two patterns, the latter is more decoupled, which means that it has a greater degree of reusability and is easier to replace. The cost is that it's slightly more complicated. This is a classical tradeoff, to be made in programming and so the proper choice depends on the context. FWIW, I prefer the latter approach.

[mihd]

Between the two patterns, the latter is more decoupled, which means that it has a greater degree of reusability and is easier to replace. The cost is that it's slightly more complicated. This is a classical tradeoff, to be made in programming and so the proper choice depends on the context. FWIW, I prefer the latter approach.

it wouldn't have to be complicated if php had proper OO features


partial classes in C# solve a similar issue quite nicely

[Mau]

Why not both? Symfony works with both.

[Srirangan]

I have noticed a lot of examples in the forum are not using classes for every action rather than using methods.

Instead of

class product {
function view();
fuction insert();
function update();
}

They are using

class ProductInsert {
function execute();
}

A lot of the frameworks use the first example when implementing MVC.

My Questions:
1. Which is the correct way?
2. What are the advantages disadvantages?

Don't make classes just for the heck of it. Build classes, but get your System Architecture right. Else you'd have just wasted time and money.