Cannot assign a function to JavaScript event; o_O.

[vilStewart]

Alright, well I am trying to assign a function to a JavaScript Event for a retrieved element.

I will explain with code first :

window.onload = function() {

    var divBox = document.getElementById(someid)
    var divBox.onclick = someOtherFunction(arg,arg)

}

function someOtherFunction(arga,argb){
    var anotherDiv = document.getElementById(someid)
        anotherDiv.style.color='blue'
}

If I attempt to do something similar to the above code, it executes 'someOtherFunction' rather than just setting the onclick event to the function with the proper arguments that I need to send it.

Any suggestions ? Thanks a lot guys

[AutisticCuckoo]

What you need to assign to the .onclick property is a function (a function reference).

What you are doing is calling a function and assigning the return value from it. Unless someOtherFunction(arg,arg) returns a function reference, it won't work.

Here's one way to do it:

divBox.onclick = function() {
  someOtherFunction(arg,arg);
};

Here's another:

divBox.onclick = aThirdFunction;
 
function aThirdFunction() {
  someOtherFunction(arg,arg);
};

Note that there must be no parentheses after the function name in the assignment. This is wrong:

var divBox.onclick = aThirdFunction();

[vilStewart]

Hmm, I was going to try that but I didn't, duh... thanks a LOT.

Got it all working now.

cheers

[kyberfabrikken]

Oh, and the var keyword is for declaring a variable. You don't use it, when assigning to a property of an object. So that should be:

divBox.onclick = function() {
  someOtherFunction(arg,arg);
};

Instead of:

var divBox.onclick = function() {
  someOtherFunction(arg,arg);
};

[AutisticCuckoo]

Oh, and the var keyword is for declaring a variable.

Duh! I didn't even twig to that error, because I was focusing solely on the function reference/call business.

[joebert]

Man I was looking at this thread thinking I know damn well I replied to it earlier today. Then I realized I replied to it on another forum.

[vilStewart]

Lool Joe...

thanks kyber and cuckoo, yeah I didn't even notice I did that in the example code I put up, just had that problem in the example

Thanks again guys!