If Statement Trouble

[Struggling]

I am trying to combine an if statement with a case statement which is needed to determine which submit button the user has clicked on the form from the previous page.

The form page

<FORM ACTION="ordersearchresults.php" METHOD="GET" NAME="frmSearchCriteria">

<table class="searchtable">
                      <tr>
                         <td class="leftside">Choose Category :</td>
<td>
<select name="type">
<option value="ordernumber">OrderNumber</option>
<option value="partnumber">PartNumber</option>
<option value="accountname">AccountName</option>
</select>
</td>
</tr>

<tr>
                         <td class="leftside">Enter Keyword:</td>
<td><input type="text" name="keyword"></td>
</tr>

<tr>

<td class="leftside"><INPUT TYPE="Submit" name="exact match" VALUE="Exact Match"></td>
<td class="leftside"><INPUT TYPE="Submit" name="contains" VALUE="Contains"></td>
</tr>
</FORM>

The following page is where I am getting my error

<?php


require_once('databaseconnection.php'); 

$keywordentered = $_GET['keyword']; 
 
switch($_GET['type']) {
  case 'ordernumber':
  if ($_GET['contains']) {
     $result = odbc_exec($odbc, "SELECT * FROM orderpartnumbertable WHERE Order_No LIKE '".$keywordentered."%'"); }
	 else {
	 $result = odbc_exec($odbc, "SELECT * FROM orderpartnumbertable WHERE Order_No LIKE $keywordentered" ); }
    break;
  case 'partnumber':
   if ($_GET['contains']) {
     $result = odbc_exec($odbc, "SELECT * FROM orderpartnumbertable WHERE Part_No LIKE '".$keywordentered."%'"); }
	 else {
	 $result = odbc_exec($odbc, "SELECT * FROM orderpartnumbertable WHERE Part_No LIKE $keywordentered"); }
    break;
  case 'accountname':
    if ($_GET['contains']) {
     $result = odbc_exec($odbc, "SELECT * FROM orderpartnumbertable WHERE Account_Name LIKE '".$keywordentered."%'"); }
	 else
	 $result = odbc_exec($odbc, "SELECT * FROM orderpartnumbertable WHERE Account_Name LIKE $keywordentered" ); 
    break;
}

echo '<table class="table">';
echo '<tr><th>Order Number</th><th>Part Number</th><th>Part Description</th><th>Order Quantity</th><th>Order Date</th><th>Account Name</th><th>More Info</th></tr>';
while (($row = odbc_fetch_array($result)) !== false) {
echo '<tr>';
echo '<td>' . $row['Order_No'] . '</td>';
echo '<td>' . $row['Part_No'] . '</td>';
echo '<td>' . $row['Part_Description'] . '</td>';
echo '<td>' . $row['Order_Qty'] . '</td>';
echo '<td>' . $row['Order_Date'] . '</td>';
echo '<td>' . $row['Account_Name'] . '</td>';
echo '<td>' . '<a href="ordersearchdetails.php?fnp_site=' . rawurlencode($row['FNP_Site']) . '">More Info</a>' . '</td>'; 
echo '</tr>';
}
echo '</table>'; 
?>

The lines in red are where the error is occurring and here is the error

Warning: odbc_exec() [function.odbc-exec]: SQL error: [Microsoft][ODBC Microsoft Access Driver] Too few parameters. Expected 1., SQL state 07001 in SQLExecDirect in C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\swiftdist\ordersearch\ordersearchresults.php on line 30

This relates to the first red line but the second red line brings up the same error.

[kleineme]

Just a guess: you don't have quotation marks around $keywordentered in those red lines.

[Struggling]

I don't have it on my first one either are they needed??? I have tried various ways but it still doesn't work, what is the correct way to create that line???

Cheers

[spikeZ]

You stil need sinqle quotes around the variable....

 $result = odbc_exec($odbc, "SELECT * FROM orderpartnumbertable WHERE Part_No LIKE '$keywordentered'"); } 

[Jake Arkinstall]

May I suggest a more efficient way of doing it?

<?php
require_once('databaseconnection.php'); 
$keywordentered = $_GET['keyword']; 
$possarray = array("ordernumber" => "Order_No", "partnumber" => "Part_No", "accountname" => "Account_Name");
if ($_GET['contains']) {
    $querystring = "SELECT * FROM orderpartnumbertable WHERE %s LIKE '%%%s%%'";
}else{
    $querystring = "SELECT * FROM orderpartnumbertable WHERE %s LIKE '%s'";
}
$result = mysql_query(sprintf($querystring, $_GET['type'], $possarray[$keywordentered]));
echo "<table class=\"table\">\n<tr><th>Order Number</th><th>Part Number</th><th>Part Description</th><th>Order Quantity</th><th>Order Date</th><th>Account Name</th><th>More Info</th></tr>";
while ($row = odbc_fetch_array($result)) {
    echo '<tr>';
    $displayarray = array("Order_No", "Part_No", "Part_Description", "Order_Qty", "Order_Date", "Account_Name");
    foreach($displayarray as $value){
        printf("<td>%s</td>", $row[$value]);
    }
    printf("<td><a href=\"ordersearchdetails.php?fnp_site=%s\">More Info</a></td>\n</tr>", rawurlencode($row['FNP_Site']));
}
echo "</table>"; 
?>

[Struggling]

Cheers for the help guys I will look into them examples and see what I get.

I now have another simple error i think. I am trying to pass 2 values via a link but can't get it to work with 2 variables in the code.

echo '<td>' . '<a href="ordersearchdetails.php?fnp_site=' . rawurlencode($row['FNP_Site']) . & Order_No='. rawurlencode($row['Order_No'])' . '">More Info</a>' . '</td>';

I am getting the following error


Parse error: parse error, unexpected '&' in C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\swiftdist\ordersearch\ordersearchresults.php on line 49


I have tried various ways but can't get it to work so any help most appreciated.

Cheers

[Jake Arkinstall]

you're missing a quote after the first variable:

echo '<td><a href="ordersearchdetails.php?fnp_site=' . rawurlencode($row['FNP_Site']) . '&Order_No='. rawurlencode($row['Order_No'])' . '">More Info</a>' . '</td>'; 

However, for readability I would suggest using printf():

printf("<td><a href=\"ordersearchdetails.php?fnp_site=%s&Order_No=%s\">More Info</a></td>", rawurlencode($row['FNP_Site']), rawurlencode($row['Order_No'])); 

[taliesinnz]

you also have a extra quote after the second varible

echo '<td><a href="ordersearchdetails.php?fnp_site=' . rawurlencode($row['FNP_Site']) . '&Order_No='. rawurlencode($row['Order_No']) . '">More Info</a>' . '</td>'; 

[Struggling]

Cheers for the help guys most appreciated.