Help with If Else Statement

[ColinHughes]

Hi

Can somebody please help with this statement I seem to have not quite got it right.

<?php
 
 
if($c=='1');
 
  {
 
   echo ("<input type="image" onClick="javascript:window.location.href='<?=$pre?>enquiry<?=$exv?>?id=<?=$d[id]?>&propertyref=<?=urlencode($d[propertyref])?>'" value='For Enquiry'  src="<?=$pre?>images/forenquiry.gif" title="Link To Enquiry Page" alt="Link To Enquiry page." align="left">");
 
  }
 
	else
 
  {
 
 
   echo ("<input type="image" onClick="javascript:window.location.href='<?=$pre?>enquiry<?=$exv?>?id=<?=$d[id]?>&propertyref=<?=urlencode($d[propertyref])?>'" value='For Enquiry'  src="<?=$pre?>images/forenquiry.gif" title="Link To Enquiry Page" alt="Link To Enquiry page." align="left">
 
 
 
<input type="image" "javascript:void(0)"
onclick="window.open('<?=$pre?>avail<?=$exv?>?propertyref=<?=urlencode($d[propertyref])?>',
'Calendar','width=270,height=400')" src="<?=$pre?>images/availability.gif" title="Link To Availability Calendar. Link opens in new window" alt="Link To Availability Calendar. Link opens in new window" align="right">");		
 
 
 
  }
 
 
?>

Regards

C

[Jake Arkinstall]

Hey.
Don't put semi-colons after the if(), and remember to backslash the quotes in strings. Also, don't use <?= ...?> in the middle of a string. Oh, and echo shouldn't have colons.

<?php
if($c==1){
   echo "<input type=\"image\" onClick=\"javascript:window.location.href='".$pre."enquiry".$exv."?id=".$d[id]."&propertyref=".urlencode($d[propertyref])."'\" value='For Enquiry'  src=\"".$pre."images/forenquiry.gif\" title=\"Link To Enquiry Page\" alt=\"Link To Enquiry page.\" align=\"left\">";
}else{
   echo "<input type=\"image\" onClick=\"javascript:window.location.href='".$pre."enquiry".$exv."?id=".$d[id]."&propertyref=".urlencode($d[propertyref])."'\" value='For Enquiry'  src=\"".$pre."images/forenquiry.gif\" title=\"Link To Enquiry Page\" alt=\"Link To Enquiry page.\" align=\"left\"><input type=\"image\" \"javascript:void(0)\"onclick=\"window.open('".$pre."avail".$exv."?propertyref=".urlencode($d[propertyref])."','Calendar','width=270,height=400')\" src=\"".$pre."images/availability.gif\" title=\"Link To Availability Calendar. Link opens in new window\" alt=\"Link To Availability Calendar. Link opens in new window\" align=\"right\">";
}
?>

[ColinHughes]

Thanks a lot for your reply. Too many late nights with a head cold. That is my excuse anyway

[Jake Arkinstall]

I've got the same

[ColinHughes]

Ok so now I have a further problem.. Firefox quite happily opens a new window as per the code below and displays the contents perfectly. IE shows the link button and the hover text but refuses to open the link.

This is driving me crazy(er)

 
 
   <input type=\"image\" \"javascript:void(0)\"onclick=\"window.open('".$pre."avail".$exv."?propertyref=".urlencode($d[propertyref])."','Calendar','width=270,height=400')\" src=\"".$pre."images/availability.gif\" title=\"Link To Availability Calendar. Link opens in new window\" alt=\"Link To Availability Calendar. Link opens in new window\" align=\"right\">";

Regards

C

[Jake Arkinstall]

try this:

echo "<input type=\"image\" onclick=\"window.open('".$pre."avail".$exv."?propertyref=".urlencode($d[propertyref])."','Calendar','width=270,height=400'); return false;\" src=\"".$pre."images/availability.gif\" title=\"Link To Availability Calendar. Link opens in new window\" alt=\"Link To Availability Calendar. Link opens in new window\" align=\"right\">";

[ColinHughes]

So basically I didn't need the javascript:void(0)?

It now works so a big thanks to arkinstall