multiple line deletion

[pea]

Hello, i've got a simple problem i can't figure out. I've got a text file database, i need to delete lines with a certain detail.

My file looks like this:

<?php die(); ?>
a|1|September 3rd 07|1|1
a|2|September 3rd 07|2|1
a|2|September 3rd 07|2|1
a|3|September 3rd 07|3|1

and my code:

$filearray = file($commentfile);
unset($filearray[0]);

foreach($filearray as $lnum => $thisline){
$break = "|";
list($name_comm, $comment, $date, $id, $status)=explode($break,$thisline);

if($_GET['delete'] == $id){
unset($filearray[$lnum]);
}
}

$fd = fopen ($commentfile, "w");
fwrite ($fd, "<?php die(); ?>\n");

$all = count($filearray);
for($i = 1; $i < $all; $i++) {
fwrite ($fd, $filearray[$i]);
}

fclose($fd);

When the script is used to, for example delete lines with 2 in, it deletes those *and* lines with 1 in. I think this is because when the line is unset, it doesn't match the $lnum. But i'm not sure.

Thanks

[_Steve_]

I would read each line of the file and put it into an array. Then loop the array and whatever doesn't match put it in another array, then write to file.

[pea]

Thought it'd be that simple. Thanks

[gRoberts]

Is there a reason for using a Text based DB? Would it not be better to use XML ?

If you must use text based, then i'd load each line into an array, and then write the file back but use an if to only write back if it doesn't match the id.

ie..

<?php

    $lines = array(); // this would contain all the lines from the file.

    foreach($lines as $line) {
        $lineData = explode('|', $line);
        if(lineData[0] != $_GET['delete'])
            fwrite($fd, $line);
    }

    fclose($fd);

?>

[pea]

I'll try it.

I don't have/ need an SQL database.

[gRoberts]

Your script removes from teh array, the one I posted does not. It simply goes through the array and writes to the file but ignores any lines that match your criteria

[pea]

It still has the same problem, although it seems impossible. I must have an error somewhere else.

[gRoberts]

There must be an error with your data then. As long as your data is seperated by new lines, and each line is then in turn seperated by pipes (|) then the script will work.

[siteguru]

$filearray = file($commentfile);
echo "<pre>";
print_r ($filearray);
echo "</pre>"; 

That should show on screen what PHP is seeing as the file data in the first array. Might help in debugging.

[pea]

I think i've found the problem. $_GET['delete'] wasn't the id, it was the line number.

[logic_earth]

Text File DBs are so inefficient. Not to mention old very very old.
No wonder man invent better DB system then plain old text files.

[pea]

Sorry but i'm not the type of person who buys things because they're trendy I'm not paying 1/3 more for my hosting until i *actually* need a database. I'm handling 600+ members, 2500 links and 40 tutorials very well for now.

[logic_earth]

What? buy what things? MySQL is free, SQLite is free, XML is free. What do you mean by "buy" you are not buying a thing. They are trendy for a reason they work really really damn well.

You need to get your facts straight. If they were trendy they would not be around for as long as they are. So they are not trendy they are here until someone finds something better. And plain text is not that.

Oh also Orcal has afree developer edition.
Microsoft has a free version of SQL Server 2005.

There are so many free Relational database systems you have nothing to buy.

[pea]

Not everyone on this planet has a server. I have to rent space on someone elses. This means paying more for features.

[logic_earth]

If your server does not come with PHP and MySQL you are being ripped off.

The cheapest web host on the plant package PHP and MySQL together. If your host doesn't give that to you find a new host because seriously I've not seen a hosting package that doesn't have those two item in it.

I was paying less then $80 bucks a year and I got that I could probably pay less and still get it.

[pea]

Well i'm paying about $40 (£20). This is english, i'm sure i can pay dirt for a host in america. I can upgrade to a package with mysql for £30 ($60) but as i said, i DO NOT NEED IT (please read twice).