check box result into database

[chris2108]

I am trying to take the result from a check box and enter it into mysql. The column type in the database is ENUM('n','y')

All i get is no value in the database. Please advise where i am going wrong

Thanks

<?php
if (isset($_POST['joketext'])):
 
//a new joke has been entered
//using the form below
 
$aid = $_POST['aid'];
$joketext = $_POST['joketext'];
$visible = $_POST['visible'];
 
if ($aid == '') {
	exit('<p>you must choose an author for this joke. click ' .'"back" and try again.</p>');
}
 
$sql = "insert into joke set
	joketext='$joketext',
	jokedate=CURDATE(),
	visible='$visible',
	authorid='$aid'";
if (@mysql_query($sql)) {
	echo '<p> New joke added</p>';
}else {
	echo '<p> Error adding new joke: ' .
	mysql_error() . '</p>';
}
 
?>
 
 
 
<?php 
 
echo "<p><label><input type='checkbox' name='visible' " .
	" />Tick for joke to be viewed by everyone</label><br /></p>";
 
?>
 
 
<input type="submit" value="SUBMIT" />
</form>			
<?php endif; ?>
 
<?php 
if(isset($_POST['visible'])) {
	$visible = 'y';
} else {
	$visible = 'n';
}
?>

[Jake Arkinstall]

try changing

$visible = $_POST['visible']; 

to

if(!is_null($_POST['visible'])){$visible = true}else{$visible = false); 

[BrandonK]

if (!empty($_POST['visible'])) $visible = 'y';
else $visible = 'n'; 

Also, I would recommend using tinyint(1) (1 for true, 0 for false) instead of enum. Enum is a close relative of the devil, just read the manual or ask in the MySQL forum.

[earl-grey]

Try moving:

if(isset($_POST['visible'])) {
    $visible = 'y';
} else {
    $visible = 'n';
} 

after:

$visible = $_POST['visible']; 

And some general advices:

1) don't use MySQL's enums;
2) use INSERT INTO table (field1, field2) VALUES (value1, value2) syntax instead of what you're using, as the former is the standard one;
3) don't put quotes around numeric values (assuming that author id is integer in your case);
4) protect your script from SQL Injection

[Dan Grossman]

$visible = isset($_POST['visible']) ? 1 : 0; 

I second the nomination of TINYINT for this column

[Jake Arkinstall]

Dan, quick question related to the alternative "if" code you just submitted.

I have used if statements like that before:

$var = ($ifstatement) ? $iftrue : $iffalse; 

But what is the method called?

I am thinking of writing a tutorial on handy methods which aren't very well known, but I can't find out what that method's called.

[Dan Grossman]

The ternary operator.

[Jake Arkinstall]

Thanks.

[chris2108]

Thanks everyone for you help
Regarding ENUM's, i used this becuase it is what in said in Kevin Yanks 'PHP and mysql book'. I see 3 of you do not like them so i'll try the other way using tinyint(1).
Thanks for all the other hints everyone.

[BrandonK]

I really recommend looking at the MySQL threads about ENUM. Its a nasty "nonstandard" (as Rudy would stress) datatype.