Validation failing when updating attributes

[CHeeSeBLiND]

Hi guys,

I'm pretty new to rails and I'm having a problem with my app failing validations on my user model when updating attributes.

I've got a page where users can update various things about their profile. The problem is when I submit the form, I get errors about the password validation failing despite the password isn't being passed via the form.

I'm just trying to update the country and DOB of a user.

Any help would be great.

[Fenrir2]

Define password= like this:

class User < ActiveRecord::Base
  def password=(new_password)
     write_attribute :password, new_password unless new_password.blank?
   end
end

[CHeeSeBLiND]

Hi, Thanks for the reply.

My current password= method is as follows:

  def password=(pass)
    @password=pass
    self.salt = User.random_string(10) if !self.salt?
    self.hashed_password = User.encrypt(@password, self.salt)
  end

How could I edit that so it works?

Thanks.

[Fenrir2]

Sorry, now I'm thinking about this again and I don't think this will fix it. Can you post the relevant view & controller code?

[CHeeSeBLiND]

View (edit.rhtml)

<% form_for :user, :html => { :class => 'cmxform', :multipart => true } do |f| %>
    <%= error_messages_for 'user' %>
    <fieldset>
        <legend>Personal Details</legend>
        <ol>
            <li>
                <label for="user_country">Country</label>
              <%= f.country_select :country, ['United States', 'Canada', 'United Kingdom'] %>
          </li>
          <li>
              <label for="user_birth_date">Date of Birth</label>
              <%= f.date_select :birth_date, :order => [:day, :month, :year], :start_year => 1930 %>
            </li>
        <li>
            <label for="user_avatar">Display Image</label>
            <%= file_column_field 'user', 'avatar' %>
        </li>
            <li>
                <%= submit_tag 'Update Profile', :class => 'button' %> 
        </li>
    </ol>
    </fieldset>
<% end %>

Controller

  ...snip...
  def edit
      @user = User.find_by_id(session[:user_id])
      if request.post?
            if @user.update_attributes(params[:user])
                flash[:message] = "Profile updated!"
            end
        end          
  end
...snip...

Thanks.

[Fenrir2]

This code looks good. Can you post the data in your db + your validations?

[CHeeSeBLiND]

class User < ActiveRecord::Base
    acts_as_commentable
 
    has_many :images
 
  validates_length_of :login, :within => 3..40
  validates_length_of :password, :within => 5..40
  validates_presence_of :login, :email, :password, :password_confirmation, :salt
  validates_uniqueness_of :login, :email
  validates_confirmation_of :password
  validates_format_of :email, :with => /^([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})$/i, :message => "Invalid email"  
    validates_file_format_of :avatar, :in => ["gif", "png", "jpg"]     
...snip...

[Skyblaze]

Hi, Thanks for the reply.

My current password= method is as follows:

  def password=(pass)
    @password=pass
    self.salt = User.random_string(10) if !self.salt?
    self.hashed_password = User.encrypt(@password, self.salt)
  end

How could I edit that so it works?

Thanks.

AWDWR login system code?

[Fenrir2]

Maybe the record in the db you're updating contains a non-valid password?

[CHeeSeBLiND]

AWDWR login system code?

It was from some tutorial I found on a website. Alas, I can't remember which one it was haha. Still not read through AWDWR yet.

Think I might give i a read actually.

Maybe the record in the db you're updating contains a non-valid password?

id login hashed_password email salt created_at country birth_date avatar
2 test c172d663df50ddf85abeaffb576c88ca4b064a26 admin@test.com 1NVcvPoCUg 2007-07-02 16:40:29 United Kingdom 1984-07-13 6tVQBX6Q.jpg

[Fenrir2]

validates_presence_of ... :password, ...

but no password in the db. Do you see the problem?

[CHeeSeBLiND]

There's the hashed password but not the actual password. Or the password_confirmation for that matter.

How could I go about just updating the fields that are shown in the view posted above without the user having to input their password?

[Fenrir2]

:if the validation:

validates_presence_of :password, :if => :new_password?

def new_password?
  not (hashed_password and password.blank?) # made up by my subconsciousness, don't trust.
end

[CHeeSeBLiND]

Ah brilliant.

Thanks a lot

[sagework]

Hmm,

I would suggest hashing the password in before_save filter of the model.