inserting into database

[chrissss]

hi
im working on a personal project, i have apache,mysql and php all working fine on my machine, i can perform a select query through a web form but i cant seem to put anything into the database through a web form.

im thinking this has something to do with a password although i have set one up using the grant command in mysql

anyways here some of the code

@ $db = mysql_pconnect("localhost","bookorama","bookorama123");

if (!$db)
{
echo "Error: Could not connect to database. Please try again later.";
exit;
}

mysql_select_db("books");
$query = "insert into books values ('".$isbn."', '".$author."', '".$title."', '".$price."')";
$result = mysql_query($query);
if ($result == true){
echo mysql_affected_rows()." book inserted into database.";
}
else {echo "**** didnt work again";}

by the way this is all being done using windows98 and im starting mysql by navigating through explorer and clicking on the file but i never get asked for any passwords ! am i starting it the right way ?

cheers chris

[Mark T.]

You are starting it the right way, but you need to include the names of the colums in which you want to insert the values as well.

[HarryF]

Now I get to use my signature to full effect: you don't wanna start from here;

$query = mysql_query ( "INSERT books SET isbn='$isbn', author='$author', title = '$title', price = '$price'" );

if ( !$query ) {
    echo ( "Error inserting in books: " . mysql_error()" )
} else {
    echo ( "Insert successful" );
}

Some people say for security, you want to remove the "mysql_error()" part when you go live with this, to prevent hacking.

And now.......

[Technosailor]

try a query structure like this:

INSERT INTO dbname SET
   fieldname1 = '$corrsepondingFormField1',
   fieldname2 = '$corrsepondingFormField2',
   fieldname3 = '$corrsepondingFormField3'; 

Sketch

[chrissss]

Im trying all your sugestions but i cant get past not recieving the first error msg unless i remove the user name and password then it accepts my details but doesnt enter them so im thinking it must be to do with these.

cheers chris

[Mark T.]

I totally missed that part, because my first advise would have been to remove your database username and password. I know you are running the script on localhost, but it is always best to leave those out when posting code on the forums, they have absolutely nothing to do with the working of the script.

Now, for the connection command, why not try this one:

$dbx = mysql_connect();
mysql_select_db('books', $dbx; 

Your problem was you used mysql_pconnect. I never used that string of command before, but I assume it is used to tell MySQL you are connecting with username and password -- as in mysql-passwordconnect.

Because you removed your username and password, this command could not have worked. When testing on localhost I always leave out usernames and passwords.

[DR_LaRRY_PEpPeR]

Originally posted by Mark T.
Your problem was you used mysql_pconnect. I never used that string of command before, but I assume it is used to tell MySQL you are connecting with username and password -- as in mysql-passwordconnect.

mysql_pconnect()

Because you removed your username and password, this command could not have worked. When testing on localhost I always leave out usernames and passwords.

that's simply because, by default, MySQL isn't very secure and lets you connect anonymously. try not entering a username/password on my system = no workie.

[Mytch2001]

Guys,
You might want to check the syntax of an insert command first, it seems you're all mixing inserts with updates. Here's the syntax of a propert insert command:

INSERT INTO [TableName](FieldName1, FieldName2, FieldName3) VALUES(Value1, Value2, Value3)

If you will be inserting values into every field, you can use something like this:

INSERT INTO [TableName] VALUES(Value1, Value2, Value3)

For auto incrementing fields, specify 0 as the value and MySQL will automatically update it. So a real query might look like this:

INSERT INTO Products(prodId, title, price)
VALUES(0, 'My Widget', 45.95)

[Mark T.]

Aah well, I assume you know your stuff Matt .

* MarkieMark thinks it's time to take a look at the online documentation for a few hours *