[newbie] Parse errors in PHP - what causes this?

[rawnet]

Hello Chaps,

I'm having much grief learning PHP - running up against Parse errors. I don't have much documentation on what causes there.

I know that I must put a \ sign before any " characters when I'm mixing PHP with HTML. But what else could be causing a Parse error?

Ross

[Skunk]

Normally it will be because you have a " or a ' in the wrong place or you have an uneven number of { } braces. The parse error message will normally give you a clue as to what is wrong. If you can't find the error in the line it specifies then it almost certainly means the actual mistake is in some of the lines before that line (and the error only becomes apparent to the parser in the line it has indicated).

[seanf]

If you post your code we will be able to help you find the problem

Sean

[rawnet]

Hi Guys,

Brilliant, problem solved for now, thankyou.

Appreciate your response and shall definately be visiting Sitepoint forums more often!!

All the best,

Ross

[seanf]

Originally posted by rawnet
I know that I must put a \ sign before any " characters when I'm mixing PHP with HTML

It is faster to go in and out of PHP mode, rather than mix in your HTML

Sean

[rawnet]

Okay, I spoke a bit too soon!!

I'm getting the following :

Parse error: parse error in D:\http\servicepals.com\includes\center\phpscripts.php(23) : eval()'d code on line 18

It's part of the vbPortal/vBulletin system, but it's the PHP that's falling over. I'm not sure why though, as it similar to that which I've used on others part of the page okay :

echo "<p align='left'><a href='directory/default.cfm'><IMG height=10 alt='' src='images/layout/directory.gif' width=122 border=0></a><br>
<table cellspacing=0 cellpadding=1 width='100%' border=0>
        <tr align=right bgcolor=#000066> 
          <td> 
            <table cellspacing=0 cellpadding=5 width='100%' border=0>
              <tr bgcolor=#e9e9e9> 
                <td>";
                
$query="SELECT    user.userid, userfield.field11, userfield.field12, userfield.field14, userfield.field15, userfield.field24
                FROM user
                LEFT JOIN userfield USING (userid)
                ORDER BY user.joindate DESC
                LIMIT 10";

$result = mysql_query($query);

while(list ($userid, $field11, $field12, $field14, $field15, $field24) = mysql_fetch_row($result))
print("<a href="forums/member.php?s=&action=getinfo&userid=$userid"><img src="images/small_arrow.gif" width=5 height=8 border=0><b>$field14 $field15</b></a><br>$field24, $field11 - $field12<br>
");


echo "
                </td>
              </tr>
            </table>
          </td>
        </tr>
</table></p>"; 

Any ideas guys? Not sure where I'm going wrong here!!

Cheers,

Ross

[Technosailor]

First of all, like Sean mentioned, try going in and out of PHP instead of doing it all in PHP. It's quiccker and cuts down the potential for errors. Try this:

<p align='left'>
  <a href='directory/default.cfm'>
    <IMG height=10 alt='' src='images/layout/directory.gif' 
      width=122 border=0>
  </a><br>
    <table cellspacing=0 cellpadding=1 width='100%' 
    border=0>
      <tr align=right bgcolor=#000066> 
        <td> 
          <table cellspacing=0 cellpadding=5 width='100%' 
          border=0>
            <tr bgcolor=#e9e9e9> 
              <td>
<?php                
$query="SELECT user.userid, userfield.field11, userfield.field12, userfield.field14, userfield.field15, userfield.field24 FROM user LEFT JOIN userfield USING (userid)ORDER BY user.joindate DESC LIMIT 10";

$result = mysql_query($query);

while(list ($userid, $field11, $field12, $field14, $field15, $field24) = mysql_fetch_row($result)) ?>
         
                 <a href="forums/member.php?
                  s=&action=getinfo&userid=$userid">
                 <img src="images/small_arrow.gif" width=5 
                 height=8 border=0>
                 <b><?php echo $field14."&nbsp;".
                 $field15; ?></b>
                 </a><br>
               <?php echo $field24, $field11. "-".
               $field12 ?><br>
                </td>
              </tr>
            </table>
          </td>
        </tr>
</table></p>

I have not looked at the PHP, but perhaps writing it this way will solve your problem. Let us know.

Sketch

[rawnet]

Hi Sketch,

Thankyou, but no joy. Cut and pasted that code but Getting this error still :

Parse error: parse error in D:\http\servicepals.com\includes\center\phpscripts.php(23) : eval()'d code on line 1 

Any ideas what else it could be?

Ross

[Technosailor]

Okay, well unless <p align='left'> is your first line, I'd be looking at your first line of the file for your error. It can't be in what you gave us because line 1 is HTML not PHP.

Sketch

[rawnet]

Okay. Bugger. I'm using it with vbPortal - http://www.phpportals.com - and have tried there but no joy so far. That's what will be giving strange line numbers. Shall see if I can get any luck.

Thanks anyway for the help,

All the best,

Ross

[filmfoto]

You haven't enclosed your while loop in {}. Example:

while (expression) {
    /* do some code */
} 

Cheers.

[Defender1]

I guess no one noticed this line

print("<a href="forums/member.php?s=&action=getinfo&userid=$userid"><img src="images/small_arrow.gif" width=5 height=8 border=0><b>$field14 $field15</b></a><br>$field24, $field11 - $field12<br>
"); 

You need to escape those double quotes or use single quotes dude.

[i_like_php]

i'm willing to bet you a million dollars, that you have includes within includes, trying to call it from a page not in the same directory.

[rawnet]

Aaah, thankyou i_like_php - I'll take you up on that and you can give the dosh to Defender1 - I've changed the print statement to contain single quotes and all is now working great.

Thanks for all your help guys - worked a treat - and very happy to have had so much support. I'm cross training onto PHP from Cold Fusion and am amazed how great and supportive everyone here is.

Many thanks,

All the best,

Ross