Form help please

[rctneil]

Hello,
I ahve built a comment form with some peoples help on this forum. Someone then suggested that guests may not want there email address to be visible on the site so i decided to add a checkbox to ask them. If ticked the address could be displayed. If unchecked then it couldn't. I want the box to be checked by default. I have tried it but something is always wrong and I cannot get that part to work. Below is the code i am using. Can anyone try to figure out where I am going wrong?

<?php
$form_name = null;
$form_email = null;
$form_comment = null;
$form_rating = null;
$form_emailshow = null;
$error="";
?>

<?php
if (isset($_POST['submit'])) { //If form HAS been submitted

if (!empty($_POST['name'])) {
$form_name = $_POST['name'];
$form_name = htmlentities($form_name);
$form_name = mysql_real_escape_string($form_name);
}else{
$form_name = null;
$error.="Enter your name<br />";
}

if (!empty($_POST['email'])) {
$form_email = $_POST['email'];
$form_email = htmlentities($form_email);
$form_email = mysql_real_escape_string($form_email);
}else{
$form_email = null;
$error.="Enter your email<br />";
}

if (!empty($_POST['rating'])) {
$form_rating = $_POST['rating'];
$form_rating = htmlentities($form_rating);
$form_rating = mysql_real_escape_string($form_rating);
}else{
$form_rating = null;
$error.="Choose your rating<br />";
}

if (!empty($_POST['comment'])) {
$form_comment = $_POST['comment'];
$form_comment = htmlentities($form_comment);
$form_comment = mysql_real_escape_string($form_comment);
}else{
$form_comments = null;
$error.="Enter your comment<br />";
}

if ($_POST['emailshow'] = 1) {
$form_emailshow = $_POST['emailshow'];
$form_emailshow = htmlentities($form_emailshow);
$form_emailshow = mysql_real_escape_string($form_emailshow);
$form_emailshow = 1;
} else {
$form_emailshow = 0;
}

$form_auth = 0;
$form_auth = htmlentities($form_auth);
$form_auth = mysql_real_escape_string($form_auth);

$form_rideid = $rideid;
$form_rideid = htmlentities($form_rideid);
$form_rideid = mysql_real_escape_string($form_rideid);

if (!empty($error)) {
echo '<p style="color:#ff0000; class="center">' . $error . '</p>';
require('comment_form.inc.php');
} else {



//Add comment into database and send e-mail
$addcomment = mysql_query("INSERT INTO atm_ridecomments (comment_name, comment_email, comment_rating, comment_comment, comment_auth, comment_rideid, comment_emailshow) VALUES('$form_name', '$form_email', '$form_rating', '$form_comment', '$form_auth', '$form_rideid', '$form_emailshow')") or die(mysql_error());

if ($addcomment) {
echo '<p>Comment added successfully.</p>';
}else{
echo '<p>Comment failed.</p>';
}



$subject = 'Thanks for posting a comment.';

$message = 'Hello,/nThanks for submitting a comment on Alton Towers Mania - www.atmania.com /n/nYour comment will be authorised and then posted up on the site./n/nThanks Again/nAlton Towers Mania';

if (@mail($form_email, $subject, $message)) {
echo('<p>Confirmation E-Mail sent.</p>');
} else {
echo('<p>Confirmation E-Mail failed to send.</p>');
}
}





}else{ //If form HAS NOT been submitted then show form
?>

<?php
require('comment_form.inc.php');
?>

<?php
}
?>

The form itself which is included in the above code at certain points:

<div>
    <form action="<?php $_SERVER['PHP_SELF']; ?>" name="addcomment" method="post">
    <div class="input_div"><label for="name">Name:</label><input class="form" id="name" type="text" name="name" value="<?php echo $form_name; ?>" /></div><br />
    <div class="input_div"><label for="email">E-Mail Address:</label><input class="form" id="email" type="text" name="email" value="<?php echo $form_email; ?>" /></div>
    <br />
    <div class="input_div"><label for="emailshow">Show E-Mail on site?:</label><input <?php if ($form_emailshow == '0') { echo '';}else{echo 'checked="checked"';} ?> class="form" id="emailshow" type="checkbox" name="emailshow" /></div>
    <br />
    <div class="input_div"><label for="rating">Rating:</label>
        <table style="margin-left:105px;" width="60%" border="0">
        <tr>
        <td>
        <input <?php if ($form_rating == '1star') { echo 'checked="checked"';}else{echo '';} ?> class="form" type="radio" name="rating" VALUE="1star" name="1star"></td><td><img src="img/votestars/1star.gif" alt="1 Star Rating" />
        </td></tr><tr><td>
        <input <?php if ($form_rating == '2star') { echo 'checked="checked"';}else{echo '';} ?> class="form" type="radio" name="rating" VALUE="2star" name="2star"></td><td><img src="img/votestars/2star.gif" alt="2 Star Rating" />
        </td></tr><tr><td>
        <input <?php if ($form_rating == '3star') { echo 'checked="checked"';}else{echo '';} ?> class="form" type="radio" name="rating" VALUE="3star" name="3star"></td><td><img src="img/votestars/3star.gif" alt="3 Star Rating" />
        </td></tr><tr><td>
        <input <?php if ($form_rating == '4star') { echo 'checked="checked"';}else{echo '';} ?> class="form" type="radio" name="rating" VALUE="4star" name="4star"></td><td><img src="img/votestars/4star.gif" alt="4 Star Rating" />
        </td></tr><tr><td>
        <input <?php if ($form_rating == '5star') { echo 'checked="checked"';}else{echo '';} ?> class="form" type="radio" name="rating" VALUE="5star" name="5star"></td><td><img src="img/votestars/5star.gif" alt="5 Star Rating" />
        </td></tr></table>
    </div><br />

    <div class="input_div"><label for="comment">Comments:</label><textarea cols="22" rows="5" class="form" id="comment" name="comment"><?php echo $form_comment ?></textarea><br /><br />
    </div>
    <br /><br />
    <div class="center">
    <input type="submit" value="Submit Comment" name="submit" />
    <input type="reset" value="Reset Form" name="reset" />
    </div>
    </form>
</div>

Thanks

Neil

[spikeZ]

Hi Neil,

in your php code use:

$checked = isset($_POST['emailshow']) ? ' checked' : ''; 

and on your form:

<input <?php  echo $checked; ?> class="form" id="emailshow" type="checkbox" name="emailshow"  />

[Raju Gautam]

I found there a simple mistake here in your PHP code:

if ($_POST['emailshow'] = 1) { 

Make it just like

if ($_POST['emailshow'] == 1) { 

Or simply

if ($_POST['emailshow']) { 

[rctneil]

I'm getting this error:

Notice: Undefined index: emailshow in C:\wamp\www\template atm\includes\comment.inc.php on line 49

line 49 is this:

if ($_POST['emailshow'] == 1) {

[rctneil]

Spikez, Just to ask you, Where do I put the code you suggested? At the top of the form page? or somewhere on the comment page?

[Raju Gautam]

Just replace your this line:

if ($_POST['emailshow'] = 1) { 

To

if ($_POST['emailshow']) { 

It will work.

[rctneil]

Yes, It does work but take this scenario:

If I fill in the form and keep the box CHECKED and forget the fill in 1 of the other fields, the form reloads and i get the red text saying where a field has been missed out and the checkbox retains it's check just as it should.

If the same scenario happens but the box is unchecked before submittingt he form, the form shows again with the box unchecked like it should but i get this error:

Notice: Undefined index: emailshow in C:\wamp\www\template atm\includes\comment.inc.php on line 49

[Raju Gautam]

Can we remove Notice being shown with @ before variable name like this?

<input <?php if (@$form_emailshow == 1) { echo "checked=\"checked\"";}else{ echo "";}?> class="form" id="emailshow" type="checkbox" name="emailshow" />

[spikeZ]

Neil,
replace

if ($_POST['emailshow'] = 1) { 
$form_emailshow = $_POST['emailshow']; 
$form_emailshow = htmlentities($form_emailshow); 
$form_emailshow = mysql_real_escape_string($form_emailshow); 
$form_emailshow = 1; 
} else { 
$form_emailshow = 0; 
} 

with

$checked = isset($_POST['emailshow']) ? ' checked' : ''; 

that should sort you out

[rctneil]

But wouldn't doing that upset the entering the 1 or 0 into the database field using the code in comment.php?

Thanks

Neil

[spikeZ]

ah gotcha

if(isset($_POST['emailshow'])) {
    $checked = ' checked';
    $form_emailshow = 1;
} else {
    $checked = ' ';
    $form_emailshow = 0; 

[rctneil]

When I do all that i get this error:

Notice: Undefined variable: checked in C:\wamp\www\template atm\includes\comment_form.inc.php on line 6
class="form" id="emailshow" type="checkbox" name="emailshow" />

Line 6 is this:

<div class="input_div"><label for="emailshow">Show E-Mail on site?/label><input <?php echo $checked; ?> class="form" id="emailshow" type="checkbox" name="emailshow" /></div>

[spikeZ]

$checked = '';
if(isset($_POST['emailshow'])) { 
    $checked = ' checked'; 
    $form_emailshow = 1; 
} else { 
    $checked = ' '; 
    $form_emailshow = 0;
} 

[rctneil]

I still get this showing:

Notice: Undefined variable: checked in C:\wamp\www\template atm\includes\comment_form.inc.php on line 6
class="form" id="emailshow" type="checkbox" name="emailshow" /> 

[rctneil]

Cna anyone help wit this?

[Raju Gautam]

So could you please paste your whole code once again that you might have changed it now?

[spikeZ]

Morning Neil, must have been a bit tired when i posted the last part!
it will still be undefined as it is inside the if(isset($_POST.... check.
where you have your variables at the top, add the $checked to them

<?php 
$form_name = null; 
$form_email = null; 
$form_comment = null; 
$form_rating = null; 
$form_emailshow = null; 
$error=""; 
$checked = "";
?>

That should sort it

[rctneil]

Right, That works fine but now, the box is not checked by default when the page is loaded. Do I just change the $checked variable to equal checked?

[rctneil]

Heya,
Sorted! - Yes that did work! I just changed $checked to equal checked!

Cheers all!

Thanks

Neil

[Bender51]

What was the final code?

[rctneil]

Here is the final code for the form and the comment pages:

Form:

<div>
    <form action="<?php $_SERVER['PHP_SELF']; ?>" name="addcomment" method="post">
    <div class="input_div"><label for="name">Name:</label><input class="form" id="name" type="text" name="name" value="<?php echo $form_name; ?>" /></div><br />
    <div class="input_div"><label for="email">E-Mail Address:</label><input class="form" id="email" type="text" name="email" value="<?php echo $form_email; ?>" /></div>
    <br />
    <div class="input_div"><label for="emailshow">Show E-Mail on site?:</label><input <?php echo $checked; ?> class="form" id="emailshow" type="checkbox" name="emailshow" /></div>
    <br />
    <div class="input_div"><label for="rating">Rating:</label>
        <table style="margin-left:105px;" width="60%" border="0">
        <tr>
        <td>
        <input <?php if ($form_rating == '1star') { echo 'checked="checked"';}else{echo '';} ?> class="form" type="radio" name="rating" VALUE="1star" name="1star"></td><td><img src="img/votestars/1star.gif" alt="1 Star Rating" />
        </td></tr><tr><td>
        <input <?php if ($form_rating == '2star') { echo 'checked="checked"';}else{echo '';} ?> class="form" type="radio" name="rating" VALUE="2star" name="2star"></td><td><img src="img/votestars/2star.gif" alt="2 Star Rating" />
        </td></tr><tr><td>
        <input <?php if ($form_rating == '3star') { echo 'checked="checked"';}else{echo '';} ?> class="form" type="radio" name="rating" VALUE="3star" name="3star"></td><td><img src="img/votestars/3star.gif" alt="3 Star Rating" />
        </td></tr><tr><td>
        <input <?php if ($form_rating == '4star') { echo 'checked="checked"';}else{echo '';} ?> class="form" type="radio" name="rating" VALUE="4star" name="4star"></td><td><img src="img/votestars/4star.gif" alt="4 Star Rating" />
        </td></tr><tr><td>
        <input <?php if ($form_rating == '5star') { echo 'checked="checked"';}else{echo '';} ?> class="form" type="radio" name="rating" VALUE="5star" name="5star"></td><td><img src="img/votestars/5star.gif" alt="5 Star Rating" />
        </td></tr></table>
    </div><br />

    <div class="input_div"><label for="comment">Comments:</label><textarea cols="22" rows="5" class="form" id="comment" name="comment"><?php echo $form_comment ?></textarea><br /><br />
    </div>
    <br /><br />
    <div class="center">
    <input type="submit" value="Submit Comment" name="submit" />
    <input type="reset" value="Reset Form" name="reset" />
    </div>
    </form>
</div>

Comment:

<?php $form_name = null;
$form_email = null;
$form_comment = null;
$form_rating = null;
$form_emailshow = null;
$error="";
$checked = "checked";
?>  

<?php
if (isset($_POST['submit'])) { //If form HAS been submitted

if (!empty($_POST['name'])) {
$form_name = $_POST['name'];
$form_name = htmlentities($form_name);
$form_name = mysql_real_escape_string($form_name);
}else{
$form_name = null;
$error.="Enter your name<br />";
}

if (!empty($_POST['email'])) {
$form_email = $_POST['email'];
$form_email = htmlentities($form_email);
$form_email = mysql_real_escape_string($form_email);
}else{
$form_email = null;
$error.="Enter your email<br />";
}

if (!empty($_POST['rating'])) {
$form_rating = $_POST['rating'];
$form_rating = htmlentities($form_rating);
$form_rating = mysql_real_escape_string($form_rating);
}else{
$form_rating = null;
$error.="Choose your rating<br />";
}

if (!empty($_POST['comment'])) {
$form_comment = $_POST['comment'];
$form_comment = htmlentities($form_comment);
$form_comment = mysql_real_escape_string($form_comment);
}else{
$form_comments = null;
$error.="Enter your comment<br />";
}

$checked = '';
if(isset($_POST['emailshow'])) {
$checked = ' checked';
$form_emailshow = 1;
} else {
$checked = ' ';
$form_emailshow = 0;
}

$form_auth = 0;
$form_auth = htmlentities($form_auth);
$form_auth = mysql_real_escape_string($form_auth);

$form_rideid = $rideid;
$form_rideid = htmlentities($form_rideid);
$form_rideid = mysql_real_escape_string($form_rideid);

if (!empty($error)) {
echo '<p style="color:#ff0000; class="center">' . $error . '</p>';
require('comment_form.inc.php');
} else {



//Add comment into database and send e-mail
$addcomment = mysql_query("INSERT INTO atm_ridecomments (comment_name, comment_email, comment_rating, comment_comment, comment_auth, comment_rideid, comment_emailshow) VALUES('$form_name', '$form_email', '$form_rating', '$form_comment', '$form_auth', '$form_rideid', '$form_emailshow')") or die(mysql_error());

if ($addcomment) {
echo '<p>Comment added successfully.</p>';
}else{
echo '<p>Comment failed.</p>';
}



$subject = 'Thanks for posting a comment.';

$message = 'Hello,/nThanks for submitting a comment on Alton Towers Mania - [url]www.atmania.com[/url] /n/nYour comment will be authorised and then posted up on the site./n/nThanks Again/nAlton Towers Mania';

if (@mail($form_email, $subject, $message)) {
echo('<p>Confirmation E-Mail sent.</p>');
} else {
echo('<p>Confirmation E-Mail failed to send.</p>');
}
}





}else{ //If form HAS NOT been submitted then show form
?>

<?php
require('comment_form.inc.php');
?>

<?php
}
?>