Whats Wrong with this Function

[afridy]

Hai, whats wrong with this function.

function validate_fields(){ 
if (feedback.txtname.value==""){
alert("Name is not Optional. Please Enter Your Name.");
feedback.txtname.focus(); 
return false; 
}elseif (feedback.txtemail.value==""){
alert("Please Enter Your Email Address.");
feedback.txtemail.focus(); 
return false; 
}elseif (feedback.txtcomments.value==""){
alert("Please type your message.");
feedback.txtcomments.focus(); 
return false; 
}else{
}
}

... onSubmit="return validate_fields(feedback)....

If i use only the following part. it works very well. Great Code !!
but if i put other elaseif parts,

if (feedback.txtname.value==""){
alert("Name is not Optional. Please Enter Your Name.");
feedback.txtname.focus(); 
return false; 
}

[gRoberts]

because your function() doesn't contain a parameter to pass across.

change function validate_fields() to function validate_fields(feedback)

[afridy]

Thanks gRoberts for pointing out the problem.

I just put (feedback) as you sad.
but still problem is there.

[gRoberts]

by the looks of it your passing the form across.

Your best off using document.getElementById('fieldname').value

[afridy]

ok.ill check

[afridy]

gRobert and all

The real problem with my above code is , if i put elseif part it will not work.
but only the below part, works very well.

if (feedback.txtname.value==""){
alert("Name is not Optional. Please Enter Your Name.");
feedback.txtname.focus();
return false;
}


any problem with if ... else

[gRoberts]

ok...

well if the txtname.value is empty, then the validate_fields will end, as you have return false. This means once it hits return false, it skips whats yet to come.

[afridy]

Ok gRob. but problem is, nothing happen when there is elseif added. even if the txtname is empty, it wan't alert.

[afridy]

if i remove the bleow part it works.

elseif (feedback.txtemail.value==""){
alert("Please Enter Your Email Address.");
feedback.txtemail.focus();
return false;
}elseif (feedback.txtcomments.value==""){
alert("Please type your message.");
feedback.txtcomments.focus();
return false;
}else{
}

[afridy]

oh, it was problem with 'elseif' and it should be 'else if' in java script. i come from php and did not notice this issue.

Thanks gRob for the support. the parameter issue you pointed out is also a mistake i made.

thanks.