how do i get this variable in to my function???

[elduderino]

HI,

I have this line in my html:

<input type="button" value="edit" value="<?php echo $message_id; ?>" onClick="get_message();" />

Now the value of the input above is being generated by a php script and is as always a number....theres about 10 of these spit out by the server so it ends up looking like this:

<input type="button" id="message_id"value="edit" value="1" onClick="get_message();" />
<input type="button" id="message_id" value="edit" value="2" onClick="get_message();" />
<input type="button" id="message_id" value="edit" value="3" onClick="get_message();" />

and so on.
Now i have this function ( its actually an ajax function but i only need to ask about the first line of it which is javascript!!) that is currently being run when the button is clicked:

function get_message() {
    var message_id = document.getElementById("message_id").value;
    createRequest();
    var url = "edit_message.php?message_id=" + escape(message_id);
    request.open("GET", url, true);
    request.onreadystatechange = open_message;
    request.send(null);
 
   }

Now what i want to happen is for the id that is being generated in the value of the input to make it in to the get_message() function. At present whatever button you click on only the number 1 ever makes it to the script.

I need a way to get the value of whatever button has been clicked in to my message_id variable.

Any ideas?

[dustbuster]

An easy way to do it would be something like this:

<input type="button" value="edit" value="<?php echo $message_id; ?>" onClick="get_message(<?php echo $message_id; ?>);" />

which would give you this

<input type="button" id="message_id"value="edit" value="1" onClick="get_message(1);" />
<input type="button" id="message_id" value="edit" value="2" onClick="get_message(2);" />
<input type="button" id="message_id" value="edit" value="3" onClick="get_message(3);" />

function get_message(num) {
    var message_id = num;
    createRequest();
    var url = "edit_message.php?message_id=" + escape(message_id);
    request.open("GET", url, true);
    request.onreadystatechange = open_message;
    request.send(null);
 
   }

But the problem you are currently having is due to the fact that all of your ids are the same. In order to get different values you need to have different ids.

Like so (don't mind the imperfect coding here )

<input type="button" id="message_id_<?php echo $message_id; ?>" value="<?php echo $message_id; ?>" onClick="get_message(this);" />

which would give you this

<input type="button" id="message_id_1" value="1" onClick="get_message(this);" />
<input type="button" id="message_id_2" value="2" onClick="get_message(this);" />
<input type="button" id="message_id_3" value="3" onClick="get_message(this);" />

function get_message(msg) {
    var message_id = msg.value;
    createRequest();
    var url = "edit_message.php?message_id=" + escape(message_id);
    request.open("GET", url, true);
    request.onreadystatechange = open_message;
    request.send(null);
 
   }

hth a bit

[elduderino]

hi there...thats great...worked a treat and ive also added the 'this' concept to my javascript arsenal also!

Thanks for your time

[dustbuster]

np