Image upload - verify file type help

[adammc]

Hi guys,

Im having trouble getting this to work, i want to validate that the uploaded image ($picture) is a gif or jpeg.

// Validate the image type. Should be jpeg, jpg, or gif. 
        $allowed = array ('image/gif', 'image/jpeg', 'image/jpg'); 
        if (in_array($_FILES['picture']['type'], $allowed)) 
        { 
        $errors['picture2'] = 'Please ensure the image is a JPEG or GIF.';   
    } 

Can anyone possibly help?

[hexburner]

From php.net:

$_FILES['userfile']['type'] The mime type of the file, if the browser provided this information. An example would be "image/gif". This mime type is however not checked on the PHP side and therefore don't take its value for granted.

This should be better then:

function file_extension($filename) {
  return strtolower(end(explode(".", $filename)));
}
 
$allowed = array('gif', 'jpg', 'jpeg', 'png');
if (!in_array(file_extension($_FILES['Picture']['name']), $allowed) {
    // Filetype not allowed
}

[adammc]

Hi hexburner

Thank you!!!, that did the trick

One last question...
Do you know a better routine to check the dimensions of an image?

This one wont validate true for a 120wide x 90high image?

// Get image width and height and mime type
    $image = getimagesize("$picture");
    $type = $image['mime'];
    $width = $image[0];
    $height = $image[1];

// Validate the pictures dimensions (length & width set in config file)
if(($image[0] > $max_width) || ($image[1] >$max_height)) {
$errors['picturedimensions'] = "Your image must not exceed ". $max_height . " x ". $max_width .".";     
    } 

[logic_earth]

I would use getimagesize to verify that the image is an image and the size.

// Validate the image type. Should be jpeg, jpg, or gif. 
$allowed = array ('image/gif', 'image/jpeg', 'image/jpg'); 
if (in_array($_FILES['picture']['type'], $allowed)) { 
    $errors['picture2'] = 'Please ensure the image is a JPEG or GIF.';
}

Would be replace with

if (($gi = getimagesize($_FILES['picture']['tmp_name'])) === false) {
    // Not an image exit...
} else {
    list($width, $height, $type) = $gi;
 
    $allowed = array(IMAGETYPE_GIF, IMAGETYPE_JPG, IMAGETYPE_PNG);
    if (!in_array($type, $allowed)) {
        // Bad File...
    }
 
    if (($width > $max_width && $height > $max_height)) {
        // Bad Width...
    }
}

Not tested but should be something like that. If the file is not an image it will error out.

Checking the extension is not enough to verify it is indeed what it is.

[Raju Gautam]

What you mean? Your code seems to be working fine. Could you please tell us that in which condition the image 120x90 could not be validated?

I don't think that there is another such way of finding the image dimensions.

[adammc]

rajug,

I just created 2 different images 120wide x 90high, the script wont let me submit but it will accept an image of a much smaller size??

Maybe my settings in the config file causing the error?

$max_height = 120;
$max_width = 90; 

Or is the settings of image width and height wrong?

[adammc]

I just saw it!!
LOL sorry for the silly mistake guys

$max_height = 120;
$max_width = 90;