Error: missing name after . operator

[Dan Grossman]

JavaScript isn't my strong suit... I've tried writing this line 4 different ways, always getting the same error. How can I rewrite all the URLs inside an iframe to call a JavaScript function with the URL as an argument instead of go to their original destination?

var clicks = [];

function markMeUp(arr) {
	
	clicks = arr;
	frame = document.getElementById('overlay_frame');
	
	var linkList;
	for (var i = 0; i < frame.contentDocument.links.length; i++) {
		link = frame.contentDocument.links[i];
		if (link.href.indexOf('#', 0) > 0) {
			link.href = link.href.substring(0, link.href.indexOf('#', 0));
		}
		iconify(frame, link);
	}
	
	for (var i = 0; i < frame.contentDocument.links.length; i++) {
		var tmp = frame.contentDocument.links[i].href;
		frame.contentDocument.links[i].href = "parent.overlay('" . escape(tmp) . "')";
	}

}

Error: missing name after . operator
Source File: http://localhost/js/overlay.js
Line: 19, Column: 75
Source Code:
frame.contentDocument.links[i].href = "parent.overlay('" . escape(tmp) . "')";

[felgall]

"parent.overlay('" . escape(tmp) . "')";

should be

"parent.overlay('" + escape(tmp) + "')";

[Dan Grossman]

Gah, how stupid of me. Thanks.

[SimplyFu]

you must have a lot php influence

[Dan Grossman]

you must have a lot php influence

Heck, that's just the beginning of it. I'm juggling 5 or 6 languages a day. C# and SQL Server's brand of SQL at work, some JScript there, come home and work on websites in both PHP and Perl, MySQL's version of SQL for those, and a Java app occasionally I'm trying to finish.

[dionak]

Thanks for this post. I did the same thing a second ago, using the Perl/PHP concat operator instead of the '+' in JS.