What did I do wrong - tips please

[t0WL337]

<?php
// This is where I get user info
$query = 'SELECT id, username, iwins, ilosses, ipoints FROM punbb2_users';
$result = mysql_query($query) or die('Query failed: ' . mysql_error());
		
$line = mysql_fetch_array($result, MYSQL_ASSOC);
?>

<dl>
     <dt>Player: </dt>
	<dd><?php echo $line['username'] ?></dd>
	<dt>Wins:</dt>
	<dd><?php echo $line['iwins'] ?></dd>
	<dt>Losses:</dt>
	<dd><?php echo $line['ilosses'] ?></dd>
	<dt>Points:</dt>
	<dd><?php echo $line['ipoints'] ?></dd>
	<dt>To Player:</dt>
	<dd><a href="">Send Challenge</a><a href="">&nbsp;</a></dd>

Okay so this is part of a custom profile I created for my users. To see an example go to this site. Click one of the usernames and it will take you to the page where the above code is used.

Now the problem is that it is always using the same user to output no matter which user you click on. Why is this happening? How can I fix it?
If you want more info leme know.

[kromey]

You need to tell MySQL which user to select. Right now, since you have no WHERE clause in your SQL statement, you are selecting all users and then using the first row in that result set.

$id = (int)$_GET['id'];
$query = "SELECT id, username, iwins, ilosses, ipoints FROM punbb2_users WHERE id=$id"; 

Now to make the profile display the proper user, your link would need to look like:

<a href="profile.php?id=1">Bob's Profile</a>

Just put the user's ID as the value of that GET parameter and you're good to go.

[Kayzio]

In your query statement you need to say something like:

 WHERE username = '$Username' 

(You are not choosing the user to select the info for)

[t0WL337]

Hey, thanks alot.

I was thinking earlier of using a WHERE clause. I just didn't really know how to do it. I am kind of new to all this. The problem was defining the variable. This works now im stoked.
thx again.