Problem with some if/elseif conditionals

[crowden]

Hi,

I'm echoing out $Rversion, which right now is giving me 3.

echo $Rversion;
        
if($Rversion=="1")
{
$SRupd = "UPDATE sales_reps SET stage='2' status='Unclaimed' WHERE sr_id = '$sr' ";
mysql_query($SRupd);
}
elseif($Rversion=="2")
{
$SRupd = "UPDATE sales_reps SET stage='5' status='Unclaimed' WHERE sr_id = '$sr' ";
mysql_query($SRupd);
}
elseif($Rversion=="3")
{
$SRupd = "UPDATE sales_reps SET stage='6' status='Completed' WHERE sr_id = '$sr' ";
mysql_query($SRupd);
} 

However, the final elseif is not running. It's running the if($Rversion=="1") every time.

What am I doing wrong here? Thanks for any help.

[spikeZ]

Personally I would use a switch() statement instead of if else:

switch($Rversion) {

case 1:
$SRupd = "UPDATE sales_reps SET stage='2' status='Unclaimed' WHERE sr_id = '$sr' "; 
break;
case 2:
$SRupd = "UPDATE sales_reps SET stage='5' status='Unclaimed' WHERE sr_id = '$sr' "; 
break;
case 3:
$SRupd = "UPDATE sales_reps SET stage='6' status='Completed' WHERE sr_id = '$sr' "; 
break;
}
mysql_query($SRupd); 

See if that makes a difference

[publi-network]

try this , must work

echo $Rversion; 
         
if($Rversion=="1") 
{ 
$SRupd = "UPDATE sales_reps SET stage='2' status='Unclaimed' WHERE sr_id = '$sr' "; 
mysql_query($SRupd); 
} 
if($Rversion=="2") 
{ 
$SRupd = "UPDATE sales_reps SET stage='5' status='Unclaimed' WHERE sr_id = '$sr' "; 
mysql_query($SRupd); 
} 
elseif($Rversion=="3") 
{ 
$SRupd = "UPDATE sales_reps SET stage='6' status='Completed' WHERE sr_id = '$sr' "; 
mysql_query($SRupd); 
} 

[crowden]

spike - Thanks for the suggestion, but it's still not working.

[crowden]

try this , must work

echo $Rversion; 
         
if($Rversion=="1") 
{ 
$SRupd = "UPDATE sales_reps SET stage='2' status='Unclaimed' WHERE sr_id = '$sr' "; 
mysql_query($SRupd); 
} 
if($Rversion=="2") 
{ 
$SRupd = "UPDATE sales_reps SET stage='5' status='Unclaimed' WHERE sr_id = '$sr' "; 
mysql_query($SRupd); 
} 
elseif($Rversion=="3") 
{ 
$SRupd = "UPDATE sales_reps SET stage='6' status='Completed' WHERE sr_id = '$sr' "; 
mysql_query($SRupd); 
} 

it did not.

[crowden]

crap, nevermind.

It wasn't my conditionals it was my sql.

See? No commas...

Thanks for the help anyway guys.

[publi-network]

no problem , ur welcome

[spikeZ]

LOL, would still go for a switch though