Iterating through an associative array.

[elfgeek]

I have an associated array that I've have created from data out of a mysql query.

When using the following code I get one extra entry output that there should be:

for( $i = 0; $i < count( $myarray ); $i++ )
{
    echo( $myarray[$i]["text"] );
} 

Is there a good way to iterate through an associative array and only output entries that exist?

thanks,
greg

[scoates]

foreach is your friend. (-:

http://php.net/foreach

foreach ($myarray AS $element) {
    echo $element["text"] 
} 

S

[elfgeek]

is this going to work for a multidimensional array that is a class member. the real code that i'm using looks more like this:

for( $i = 0; $i < count( $this->vehicles ); $i++ )
{
    $query = "select description from make where makeid = ".$this->vehicles[$i]["makeid"]." limit 0, 1";
    $result = mysql_query( $query, $db );
            
    if( $result )
    {
        $row = mysql_fetch_array( $result );
        $this->vehicles[$i]["make"] = $row["description"];
    }
    else
    {
        $this->vehicles[$i]["make"] = "Unknown";
    }
} 

[andnaess]

Not sure I understand the question, but your code can be greatly improved. No need for that for loop, instead:

$vset = Array();
foreach($vehicles as $vehicle) {
  $vset[] = $vehicle["makeid"];
}
$query = "SELECT description FROM make WHERE makeid IN (".join(',', $vset).")"; 

That will fetch you all cars in a single query, which is much better.

[elfgeek]

$vehicles already has all of the vehicles in it, it just has makeid and modelid instead of the text description of them. That is what this is for, to grab the make, and later the model and place them in the array as well.

greg

[andnaess]

Yes but there's certainly no point in executing one query per vehicle when you can use a single query to achieve the same.

[elfgeek]

I guess I'm not clear on how to achieve this.

[andnaess]

Just look at the code I posted. I extract all the vehicle id values, and then output this so that the query is like:
SELECT * FROM tablename WHERE id IN (1,2,3);

(This query will select entries with id 1, 2 or 3 if they exist).