substr trouble

[chooseodie]

Hi;
When i enter these codes

$lasttw = "<a href=\"$row[fullurl]\">$row[fullurl]</a><br />";
$lasttwshort = (strlen($lasttw)>53)?substr($lasttw,0,53).'...<br />':$lasttw;
echo "$lasttwshort"; 

or

$lasttw = "<a href=\"$row[fullurl]\">$row[fullurl]</a><br />";
if (strlen($lasttw) > 53) {
  $lasttw = substr($lasttw, 0, 53) . "...<br />";
}
echo "$lasttw"; 

i'm getting page like this;

http://www.yahoo.comhttp://www.youtu...
http://www.foru...
http://www.sitepoin...
http://http...
http://www.boardz...
http://www.gamezo...
http://rapidshare.dehttp://killervide.com...
http://www.forum...
http://www.forum...
...
...
http://
...

but i wanna get page like this;

http://www.yahoo.com/
http://www.sitepoint.com/forums/newthread.php?do=newt...

etc
(if the link is longer than 53 chars substr should add "..." automatically)

Thanks for your help...Have a nica day...

[Ize]

I use this function:

    /* make hyperlinks look pretty by shortening them a bit */
    function shortenURL ($matches)
    {
        $match        = $matches[0];
        $a_start    = "<a href=\"$match\" rel=\"rel_nofollow\">";
        $a_end        = "</a>";
        if (strlen($match)>40)
        {
            $str_start    = substr($match,0,15);
            $str_end    = substr($match,(strlen($match)-15),15);
            $match        = $str_start . '...' . $str_end;
        }
        return $a_start.$match.$a_end;
    } 

It is currently used with preg_replace_callback, but it's easy to modify it to work with just a string as the parameter. Hope that helps.

[chooseodie]

Thanks for your help Ize...
i look preg_replace_callback from php.net/preg_replace_callback but i didn't understand anything about that

[Ize]

I've altered the code for you:

/* make hyperlinks look pretty by shortening them a bit */
    function shortenURL ($match)
    {
        $a_start    = "<a href=\"$match\" rel=\"rel_nofollow\">";
        $a_end        = "</a>";
        if (strlen($match)>40)
        {
            $str_start    = substr($match,0,15);
            $str_end    = substr($match,(strlen($match)-15),15);
            $match        = $str_start . '...' . $str_end;
        }
        return $a_start.$match.$a_end;
    } 

You can now call the function like this:

print shortenURL ("http://www.sitepoint.com/forums"); 

Edit: you might want to play around with the numbers to suit your needs. As-is, the function will manipulate only strings that contain more than 40 characters.

[chooseodie]

thanks but it gives this output;

http://" rel="rel_nofollow">http://

[chooseodie]

I got what i want with this code;

$fullurl = $row["fullurl"]; 
if (strlen($fullurl) > 53) { 
    $showurl = substr($fullurl, 0, 53) . "..."; 
}else{ 
    $showurl = $fullurl; 
} 

$lasttw = "<a href=\"$fullurl\">$showurl</a><br />"; 

echo "$lasttw";

Thanks for your help Ize.