popup function, width + height not right

[bewise]

Hello all, im using the following javascript function to popup a new window that will display the full size of thumbnail images.
However, whenever I click on an image, the full image will not appear. Only a very small window will appear. How can I alter the function below so that the full image will appear?

        function popUp(URL) {
day = new Date();
id = day.getTime();
eval("page" + id + " = window.open(URL, '" + id + "', 'toolbar=0,scrollbars=0,location=0,statusbar=0,menubar=0,resizable=0,width=100%,height=100%');");
}

[jimfraser]

Hint:

height = number: Sets the height of the window in pixels.
width = number: Sets the width of the window in pixels.

[bewise]

iis there no way I can tell the popup window to open up in full screen mode?

[siteguru]

Use browser detection to determine the width and height of the screen resolution then use those values in the window.open function.

[bewise]

Why would this not work?

        function popUp(URL) {
day = new Date();
id = day.getTime();
eval("page" + id + " = window.open(URL, '" + id + "', 'toolbar=0,scrollbars=1,location=0,statusbar=0,menubar=0,resizable=0,width="screen.width",height="screen.height"');");
}

[bewise]

any ideas?

[jimfraser]

You are trying to concatenate a string to eval, but you are missing some + signs. Noone here will want to help with an eval anyway because it's just wrong. How about something like this:

//initialize the page object globally
var page = {};
...
//inside your popup function
var day = new Date();
var id = String(day.getTime());

page[id] = window.open(URL, id, "toolbar=0,scrollbars=1,location=0,statusbar=0,menubar=0,resizable=0,width=" + screen.width + ",height=" + screen.height);

note that the only reason to bother with the page object is if you want to activate the popup windows later on, and you really need to keep track of more than one of them. If not just do:

window.open(URL, "_blank", "toolbar=0,scrollbars=1,location=0,statusbar=0,menubar=0,resizable=0,width=" + screen.width + ",height=" + screen.height);