Browser compatibilty for this js code please

**Dez** · Jan 24, 2007, 15:04

Hi all,

As far as total browser compatibility and usability is concerned - is the js code in the website ok please ?

http://www.010805.com/favorites

Any help appreciated.

Regards.

Dez.

**Mittineague** · Jan 24, 2007, 19:34

Opera gives

JavaScript - http://www.010805.com/favorites/
Event thread: click
Error:
name: TypeError
message: Statement on line 7: Could not convert undefined or null to object
Backtrace:
Line 7 of linked script http://www.010805.com/favorites/bookmark.js
window.external.AddFavorite(this.href, this.title);
At unknown location
[statement source code not available]

**felgall** · Jan 24, 2007, 22:28

Only Internet Explorer allows access to add to favorites from a link. All other browsers require that the person press CTRL-D or CTRL-T depending on the browser.

To get rid of the error in modern browsers you can change it to

Code:

if (window.external && window.external.AddFavorite)
   window.external.AddFavorite(this.href, this.title);

**Kravvitz** · Jan 25, 2007, 01:18

Dez, I suggest you read this page.

Originally Posted by felgall

All other browsers require that the person press CTRL-D or CTRL-T depending on the browser.

You mean Windows browsers. Konqueror uses CTRL + B and many Mac browsers use Command/Cmd + D.

**Dez** · Jan 25, 2007, 01:40

Many, many thanks for these comments and links - they are all useful and appreciated.

I'll do some more work on it and come back to you.

One thing, the add to favs on that page *does* work with my FF - didn't it work with your FF ?

Dez.

**Kravvitz** · Jan 25, 2007, 03:08

Yes, you script adds a bookmark in FF, but the bookmark opens in the sidebar instead of in a normal window/tab. Did you not read the page I linked to?

**Dez** · Jan 25, 2007, 04:18

Originally Posted by Kravvitz

Yes, you script adds a bookmark in FF, but the bookmark opens in the sidebar instead of in a normal window/tab. Did you not read the page I linked to?

Aha, now I see - I had read the article very fully and implemented the code, but hadn't then tried to open the bookmark to see what had happened with it - now I understand the references to sidebar and side windows ;-)

Now that I understand the problem more fully, and have used the code from that link - could someone please help to get code right, as it still doesn't seem to work ?

http://www.010805.com/favorites/

It still seems to save it into the sidebar ?

Any help very much appreciated.

Dez.

**Dez** · Jan 25, 2007, 04:55

Originally Posted by felgall

Only Internet Explorer allows access to add to favorites from a link. All other browsers require that the person press CTRL-D or CTRL-T depending on the browser.

To get rid of the error in modern browsers you can change it to

Code:

if (window.external && window.external.AddFavorite)
   window.external.AddFavorite(this.href, this.title);

Many thanks Stephen - the inputs appreciated.

Would using the code above solve the sidebar problem ?

Dez.

**Mirek Komárek** · Jan 25, 2007, 05:47

It is not bad idea to add page to sidebar, but I can imagine it just with special page made just for this reason. For example left menu from here http://www.sitepoint.com/forums/ If you combine sources above with this http://home.arcor.de/xbo/sidebar-cross-browser/ and this http://www.howtocreate.co.uk/tutoria...ateSidebar.php you can develop sidebar for all most often browsers.

**Dez** · Jan 25, 2007, 07:17

Many thanks for the input Mirek - really looking to avoid the side windows.

Dez.

**Dez** · Jan 25, 2007, 07:17

Originally Posted by Dez

Aha, now I see - I had read the article very fully and implemented the code, but hadn't then tried to open the bookmark to see what had happened with it - now I understand the references to sidebar and side windows ;-)

Now that I understand the problem more fully, and have used the code from that link - could someone please help to get code right, as it still doesn't seem to work ?

http://www.010805.com/favorites/

It still seems to save it into the sidebar ?

Any help very much appreciated.

Dez.

Anyone ?

Dez.

**Kravvitz** · Jan 25, 2007, 23:26

You have violated the terms of use for that script. The comment block says that it must be included with the script. Why should we continue to help you, especially when it seems that you don't understand a lot of what you should have read?

**Dez** · Jan 26, 2007, 01:17

Thanks for the friendly reply Kravvitz - it's appreciated

I wasn't sure where to include that code, but I've now put it into the kravvitz.js file - if that's wrong, just let me know

I had read the article very fully and implemented the code, but hadn't then tried to open the bookmark to see what had happened with it - now I understand the references to sidebar and side windows ;-)

Now that I understand the problem more fully, and have used the code from that link - could someone please help to get code right, as it still doesn't seem to work ?

http://www.010805.com/favorites/

It still seems to save it into the sidebar ?

Any help very much appreciated.

Dez.

**Dez** · Jan 27, 2007, 05:32

Anyone ?

**felgall** · Jan 27, 2007, 17:45

There is no cross browser solution for anything that involves using Javascript to update anything outside of the web page since with the exception of the functionality that IE contains that is intended for use on INTRAnets most browsers provide minimal access to anything not in the page itself. As this access (small as it is) is being progressively shown to sometimes be the cause of many of the security holes in the various browsers the newer browser versions are progressively moving toward providing no access whatever to anything outside of the web page or at least limiting it to reading info about the brower itself only.

**Kravvitz** · Jan 27, 2007, 18:02

Originally Posted by Dez

Now that I understand the problem more fully, and have used the code from that link - could someone please help to get code right, as it still doesn't seem to work ?

You seem to have missed the significance of this paragraph:

The script looks for an element with the ID attribute set to "addBookmarkContainer" and appends a new link (<a>) element as a child of it.

I don't see that ID in your page.

**Logic Ali** · Jan 27, 2007, 19:36

Originally Posted by felgall

Only Internet Explorer allows access to add to favorites from a link. All other browsers require that the person press CTRL-D or CTRL-T depending on the browser.

To get rid of the error in modern browsers you can change it to

Code:

if (window.external && window.external.AddFavorite)

That test has always errored in I.E., presumably because addFavorite is type unknown.

Use: if(window.external && typeof window.external.AddFavorite != 'undefined')

**Dez** · Jan 29, 2007, 03:30

Originally Posted by Kravvitz

I don't see that ID in your page.

Thanks to all who have posted helpful comments here - it's definitely helping me to understand more about this.

Kravvitz - it may have missed your perception, but I am new to this and am trying to learn - I'm sure we've all been at that juncture at some stage ! Does that ID go in the following code please ?

<body>
<ul class="test">
<li><a class="bookmark" href="http://www.010805.com/favorites/" title="caption">Favorites</a></li>
</ul>
</body>
</html>

Also, just to clarify - doing this exactly as you kindly suggest, would the add to favorites work both in FF and IE with just 2 clicks and without any use of side windows in FF ?

Any help much appreciated.

Dez.

**Kravvitz** · Jan 29, 2007, 04:16

The unique ID should be applied to whichever element you want to be the parent of the link that the script creates.

It depends how you define "2 clicks". In Firefox you click then link, then you read the alert box and click "OK", and then press the keys it told you to press. Currently, only IE/Win and Opera 7+ provide the functionality you want.

**Dez** · Jan 29, 2007, 05:07

Originally Posted by Mittineague

Opera gives

Hi Mittineague,

Many thanks for the input on this - it is appreciated.

I assume that the solution that is being worked on with Kravvitz, would have no errors at all ?

Dez.

**Dez** · Jan 29, 2007, 05:11

Originally Posted by Kravvitz

The unique ID should be applied to whichever element you want to be the parent of the link that the script creates.

It depends how you define "2 clicks". In Firefox you click then link, then you read the alert box and click "OK", and then press the keys it told you to press. Currently, only IE/Win and Opera 7+ provide the functionality you want.

Many thanks Kravvitz - the help is appreciated.

Can anyone mention precisely what part of the code below that I would need to change at all please ?

<ul class="test">
<li><a class="bookmark" href="http://www.010805.com/favorites/" title="caption">Favorites</a></li>
</ul>

Any help is always appreciated.

Dez.

**Mittineague** · Jan 29, 2007, 10:38

The page that Kravvitz linked to doesn't throw any javascript errors in Opera. Neither does your current page at http://www.010805.com/favorites/

**Dez** · Jan 29, 2007, 12:44

Many thanks Mittineague - I was a bit confused on that - thanks for clearing it up for me

Dez.

**Kravvitz** · Jan 29, 2007, 22:40

Why would it have errors?

Code:

<ul class="test">
<li><a class="bookmark" href="http://www.010805.com/favorites/" title="caption">Favorites</a></li>
<li id="addBookmarkContainer"></li>
</ul>

**Dez** · Jan 31, 2007, 07:42

Relax Kravvitz, no-one said there were errors

Many, many thanks for the code, and for helping me to understand this whole thing ! The helps been appreciated.

Do you know if it's totally compat with all browsers, incl ie7 please ?

All the best.

Dez.

The SitePoint Forums have moved.

User Tag List

Thread: Browser compatibilty for this js code please

Thread Tools

Display

Browser compatibilty for this js code please

js err msg

js errors

Bookmarks

Bookmarks

Posting Permissions