Javascript IFrame Height Change Not Working if FF

[casbboy]

The script below works perfect at changing the height of an iframe depending on a dynamic factor.

<script language="javascript">
if (document.all) 
{
window.document.all.slideshow.style.height = 88;
}
else 
{
i = window.document.getElementById("slideshow");
i.style.height = 88;
}
</script>

What am I missing? It works perfect in IE though.

Thanks
Ryan

[dwees]

Well first off, document.all is pretty much unnecessary now-a-days with the modern browsers, unless you are trying to make sure that IE 4 recognizes your script (and I think Iframes fail in IE4 anyway) so you are probably fine to scrap the use of the conditional.

2nd, when using Javascript to set style attributes, you have to treat the attributes as strings, even if they are numbers. So hence:

i.style.height = "88px";

Note that I include the units inside the quotes.

[Logic Ali]

The script below works perfect at changing the height of an iframe depending on a dynamic factor.

<script language="javascript">
if (document.all) 
{
window.document.all.slideshow.style.height = 88;
}
else 
{
i = window.document.getElementById("slideshow");
i.style.height = 88;
}
</script>

What am I missing? It works perfect in IE though.

i = window.document.getElementById("slideshow");
i.height = 88;
i.width=600;

[casbboy]

using the px and the quotes got it working.

Thanks
Ryan

[Logic Ali]

using the px and the quotes got it working.

Just as long as you appreciate that using the style property is dependent upon CSS support being present.

[Kravvitz]

Why are you using document.all? IE5+ support document.getElementById().

What happens if an Netscape 4 user tries to use that?

My suggestion is that if you want to support IE4, you can use the following and just test for document.getElementById() support.

if(document.all && !document.getElementById) { //IE4 support
  document.getElementById = function(id) { return document.all[id]; }
}