Why won't this work?

[rctneil]

<?php

if ($style == "oblivionstyle") {
$adcolour="#000000";
}

if ($style == "hexstyle") {
$adcolour="#000000";
}

if ($style == "mainstyle") {
$adcolour="#012349";
}

if ($style == "") {
$adcolour="#012349";
}

?>




<script type="text/javascript"><!--
google_ad_client = "pub-1527442551569821";
google_ad_width = 120;
google_ad_height = 240;
google_ad_format = "120x240_as";
google_ad_type = "text_image";
google_ad_channel ="";
google_color_border = "012349";
google_color_bg = "<?php echo '$adcolour' ?>"
google_color_link = "012349";
google_color_text = "000000";
google_color_url = "00CCFF";
//--></script>
<script type="text/javascript"
src="http://pagead2.googlesyndication.com/pagead/show_ads.js">
</script>

The colour is not changing?

Regards,
Neil

[thirteenlisk]

Try this:

<?php
  if ($style == "oblivionstyle") {
  $adcolour="#000000";
  }
  
  if ($style == "hexstyle") {
  $adcolour="#000000";
  }
  
  if ($style == "mainstyle") {
  $adcolour="#012349";
  }
  
  if ($style == "") {
  $adcolour="#012349";
  }
  ?>
  
  <script type="text/javascript"><!--
  google_ad_client = "pub-1527442551569821";
  google_ad_width = 120;
  google_ad_height = 240;
  google_ad_format = "120x240_as";
  google_ad_type = "text_image";
  google_ad_channel ="";
  google_color_border = "012349";
  google_color_bg = "<?php echo $adcolour; ?>"
  google_color_link = "012349";
  google_color_text = "000000";
  google_color_url = "00CCFF";
  //--></script>
  <script type="text/javascript"
  src="http://pagead2.googlesyndication.com/pagead/show_ads.js">
  </script>

You were echoing the string "$adcolour" instead of the variable $adcolour. If you had used double-quotes ("$adcolour") it would have also worked, but you used single-quotes ('$adcolour') which will not get the variable's value.

[rctneil]

Sorry but it still shows white instead of the colour!

Thanks

Neil

[Dan Grossman]

Right click, view source.

[rctneil]

In the page code:

google_ad_channel ="";


So why isn't the value of the colour being put in there?

Regards,
Neil

[clamcrusher]

look at your php code and you will see why.

[rctneil]

I really cannot what is wrong?

[scojo1]

I really cannot what is wrong?

how are you setting the $style variable?

[rctneil]

Sorry, i get ya, the style varibale is like this:

www.example.com?style=oblivion

[Dan Grossman]

Is register_globals enabled on this server?

You should be using $_GET['style'] to access that.

[clamcrusher]

you asked why the value of this is empty
google_ad_channel ="";

did you mean to ask why this is empty?
google_color_bg = ""

thats why i said look at your code.

[rctneil]

All sorted, I have a hash in my code where i shouldn't have done