Persistant Array Indices

[J.Ryan]

Hiya folks,

I am creating a handful of buttons on the fly using ajax... Basically, what I have are two arrays of data that I get from the server (this.values[] and this.commands[]). One array contains the buttons' values, the other contains the command strings that I will send back to the server with the buttons' onClick functions. Right now, for testing, the onclick functions are just alerting the command rather than sending it back to the server. Here is my code for this:

var x;
for(x in this.values) {
       var button = document.createElement("input");
       var br = document.createElement("br");
       button.type = "button";
       button.value = this.values[x];
       button.onclick = function(){alert(this.commands[x];};
       this.cmdDiv.appendChild(button);
       this.cmdDiv.appendChild(br);
}

The result is that I get three different buttons, each showing a different (and correct) value. However, when I click on them, they all display the same command, the last one in the commands array. I then did a slight modification:

button.onclick = function(){alert(button.value);};

and discovered that this new onclick function also alerted the same value for each button, again the last entry in the array of values. Even though the webpage is showing the buttons with unique values...

So it appears that each time the iterator, x, increments, it's reassigning the previous buttons with the new current value.. so that by the time x is finished stepping through the array, all buttons have the same values for their value property and onclick funtion (the last value in the arrays).

From a programmer's perspective, this is raunchy behavior that completely nullifies the usefullness of an array.. there must be a way around this for javascript..?? Can anyone tell me how to solve this issue?

Thanks greatly!
-Jess

[Pepejeria]

Try

button.onclick = function(){ alert(this.value); };

[J.Ryan]

Hey!

Thanks for the quick reply. It works! Great!! (I've been banging my head on this one for a few days...) Whew!

-Jess