Keeping Stats on Button Clicked

[Immerse]

OK, time to do some debugging.

function increment_stats_count($conn) {
    die('Click increment point reached!');
    mysql_query("update stats set clicks = clicks + 1", $conn) or die (mysql_error());
} 

Try that. What's the point? Well, if you see 'Click increment point reached!' appearing, at least we know the function is being called. If it doesn't appear, then there's something going wrong somewhere else...

Edit>>
One more idea... have you actually selected the database proxies_stats in your script?

    mysql_query("update proxies_stats.stats set clicks = clicks + 1", $conn) or die (mysql_error()); 

[Wumble]

Ah

Well the message was not displayed

I just tried your edit, no updates

full script

$dbhost = 'localhost';
$dbuser = 'proxies_admin';
$dbpass = 'passwordremoved;

$conn = mysql_connect($dbhost, $dbuser, $dbpass) or die                      ('Error connecting to mysql');

$dbname = 'proxies_stats';
mysql_select_db($dbname);

/* Place the following on your form handling page */
function increment_stats_count($conn) {
    die('Click increment point reached!');
 mysql_query("update proxies_stats.stats set clicks = clicks + 1", $conn) or die (mysql_error()); 
}
  if(isset($_POST['browse']))
{
    increment_stats_count($conn);
}

[Immerse]

OK, so the function isn't being called.

More debug:

echo "<pre>".print_r($_POST)."</pre>";

if(isset($_POST['browse']))
{
    increment_stats_count($conn);
} 

This'll show you what's in $_POST. It seems as though $_POST['browse'] isn't set...



Edit>>
Tidied your code up a bit.

<?php

echo "<pre>".print_r($_POST, 1)."</pre>";

$dbhost = 'localhost';
$dbuser = 'proxies_admin';
$dbpass = 'passwordremoved';

$conn = mysql_connect($dbhost, $dbuser, $dbpass) or die('Error connecting to mysql');

mysql_select_db('proxies_stats', $conn);


function increment_stats_count($conn) {
    die('Click increment point reached!');
    mysql_query("update proxies_stats.stats set clicks = clicks + 1", $conn) or die (mysql_error()); 
}


if(isset($_POST['browse']))
{
    increment_stats_count($conn);
}

?>

[Wumble]

I get a very werid, unrelated msg:

Array ( )

1


Warning: Cannot modify header information - headers already sent by (output started at /home/proxies/public_html/index.php:18) in /home/proxies/public_html/proxy_system.php on line 627

function increment_stats_count($conn) {
    die('Click increment point reached!');
 mysql_query("update proxies_stats.stats set clicks = clicks + 1", $conn) or die (mysql_error()); 
}
echo "<pre>".print_r($_POST)."</pre>";

if(isset($_POST['browse']))
{
    increment_stats_count($conn);
}

Is that the correct code?

[Immerse]

Sorry, should have been:

echo "<pre>".print_r($_POST, 1)."</pre>"; 

But it doesn't matter anymore, I can see all I need to know.

$_POST is empty.

Is the button part of a form that has method="post"?

Or is a button that works in some other way?

[Wumble]

<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
<div>
<input type="submit" name="browse" value="Browse Website Safely" onclick="return submit_form();" />
</div>
</form>

Is this what you are talking about?

[Immerse]

OK, that looks fine. What does the function submit_form() do?

[Wumble]

I'm really not sure - it's part of PHProxy script

[Immerse]

OK, try putting this at the top of the page:

echo "<pre>".print_r($GLOBALS, 1)."</pre>"; 

THat'll echo out just about every variable there is. Be quick though, as it might also print out passwords and stuff. So put that in, press the button, and then take that line out again so no one else sees it...

Then, check the output to see if you see anything looking like 'browse'

[Wumble]

There is nothing regarding browse

[Immerse]

Then I'm out of ideas...
Maybe the authors of PHProxy can help you?

[Wumble]

Thanks for all your help Immerse I'll see what I can do!

[php_daemon]

Can you shows as the submit_form() code?

[Dan Grossman]

if(isset($_POST['browse']))

If someone enters a URL to view through the proxy and presses enter to submit the form, the submit button won't be in $_POST. It's also possible the javascript doesn't submit that value either. I would use a different test to see if the proxy form was submitted.

[Immerse]

Input's of type submit are available in post, aren't they?
The strange thing here is that the entire $_POST superglobal is empty.

Ooh, that gives me an idea!

CWN, what version of PHP are you running on?

[Wumble]

I'm not sure - I think 5