wrong argument type String (expected Module)

[HenriIV]

hi,

I don't understand this error. I have an STI table "properties" with different children like House, Flat, Land...
when I want to add a new property, instead of creating a new House or Flat, I do New Property and list in a select box the different types but I get this error

It works for any column in the table except the type column. Should I create directly the proper subclass (ie new Home instead of new Property)?

<p><label for="property_type">Type</label><br/>
<%= options = [["Select Type", ""]] + Property::TYPES
    select('property', 'type', options) %></p> 

where Property::TYPES is an array like that:
TYPES = [
["House", "House"],
["Flat", "Flat"],
["Plot", "Plot"]
]

[DougBTX]

I have a feeling that "type" is a reserved column name, though I'm not sure where the documentation for it is.

[vgarcia]

Yeah, try PROPERTY_TYPES

I'm guessing you're basing this on the code for the Depot app in the Agile book? It's Order::PAYMENT_TYPES in there. Even in that sample, they recommend putting the types in their own database table if there's a chance of new types being added/changed/removed.

[HenriIV]

I'm guessing you're basing this on the code for the Depot app in the Agile book?

Yes , I thought it was a reserved word so I tried PROPERTY_TYPES but I had the same message.

I should probably move it to a new table but I'll have to do another join. I have already 2 foreign keys, I thought it was enough

[sweatje]

I have no idea how kosher this code is, but I hard coded a small list of options into a view using:

<select id="answernew_correct" name="answernew[correct]">
        <%= options_for_select [["Wrong","0"],["Correct","1"]]  %>
</select>

[vgarcia]

I have no idea how kosher this code is, but I hard coded a small list of options into a view using:

<select id="answernew_correct" name="answernew[correct]">
        <%= options_for_select [["Wrong","0"],["Correct","1"]]  %>
</select>

That's fine as long as you don't repeat yourself with that array anywhere else

[HenriIV]

Still stuck with this STI stuff...

I uses a good old html select to avoid the error

<td><label for="property_type">Type</label>:</td>
    <td><select id="property_type" name="property[type]">
    <option value="Home">Home</option>
    <option value="Flat">Flat</option> 

the rendered rhtml is ok but it doesn't create/update the type column

The same code for another field does the job so there is really something wrong with STI but I don't understand what. Any idea?

[HenriIV]

I've found an interesting tip to fix this type thing on the RoR forum:
http://www.ruby-forum.com/topic/67826#new

Posted by Trevor Squires (Guest)
on 02.06.2006 01:30

On 1-Jun-06, at 2:26 PM, Josh Susser wrote:

>
> def inheritance_column
> "something_other_than_type"
> end
>

Sorry but that's not the way to go. The inheritance_column method is
a *class* method.

Regardless, I believe the correct call is set_inheritance_column. I.e.:

class MyModel < ActiveRecord::Base
set_inheritance_column :ruby_type
end

However, if you want to access the value for the 'type' field in your
table you can't do:

model.type

you have to use:

model[:type]

All in all, if you can avoid it then don't have a column called
"type". I don't even use it for STI - a while back I picked up a
habit of always setting the inheritance column to be 'ruby_type'.

That way I can do model.type() to get back the class object and
model.ruby_type (and model.ruby_type=) to access the string
representation of the class name.

I think I'm going to adopt ruby_type