I can't fiind what is wrong with this PHP script, any ideas?

**masm50** · Oct 25, 2001 16:09

I am trying to make an admin area to my site, where reviews can be added, then they would automatically become part of my site.

Here is the whole PHP script that I wrote (Thanks to the great Sitepoint tutorials):

<HTML>
<HEAD>
<title>Add New Review</title>
</HEAD>
<BODY>
<?php

if ($submit):

if ($aid == "") {
echo("<P>You must choose an author.</P>");
exit();
}

if ($lid == "") {
echo("<P>You must choose a license.</P>");
exit();
}

if ($rid == "") {
echo("<P>You must choose a rating.</P>");
exit();
}

if ($cid == "") {
echo("<P>You must choose a category.</P>");
exit();
}

$dbcnx = @mysql_connect(
"localhost", "audiomelody", "Bollinger");
mysql_select_db("audiomelody");

$sql = "INSERT INTO Reviews SET " .
"Title='$title', " .
"Version='$version', " .
"ReviewText='$reviewtext', " .
"Date='CURDATE()', " .
"FileSize='$filesize', " .
"ScreenURL='$screenurl', " .
"DownloadURL='$downloadurl', " .
"LicenseInfo='$licenseinfo', " .
"SystemReq='$systemreq', " .
"AID='$aid', " .
"LID='$lid', " .
"RID='$rid', " .
"CID='$cid'," ;
if (mysql_query($sql)) {
echo("<P>New review added</P>");
} else {
echo("<P>Error adding new review: " .
mysql_error() . "</P>");
}
?>

<?php
else:
$dcnx = @mysql_connect(
"localhost","audiomelody", "Bollinger");
mysql_select_db("audiomelody");

$authors = mysql_query (
"SELECT ID, Name FROM Authors");
$licenses = mysql_query (
"SELECT ID, Name FROM Licenses");
$ratings = mysql_query (
"SELECT ID, Name FROM Ratings");
$cats = mysql_query (
"SELECT ID, Name FROM Categories");
?>

<FORM ACTION="<?php echo(PHP_SELF); ?>" METHOD=POST>
<P>Enter Software Title

BR>
<TEXTAREA NAME="title" ROWS=1 COLS=45 WRAP>
</TEXTAREA>

<FORM ACTION="<?php echo(PHP_SELF); ?>" METHOD=POST>
<P>Enter Version

BR>
<TEXTAREA NAME="version" ROWS=1 COLS=45 WRAP>
</TEXTAREA>

<FORM ACTION="<?php echo(PHP_SELF); ?>" METHOD=POST>
<P>Enter New Review

BR>
<TEXTAREA NAME="reviewtext" ROWS=15 COLS=45 WRAP>
</TEXTAREA>

<FORM ACTION="<?php echo(PHP_SELF); ?>" METHOD=POST>
<P>Enter File Size

BR>
<TEXTAREA NAME="filesize" ROWS=1 COLS=45 WRAP>
</TEXTAREA>

<FORM ACTION="<?php echo(PHP_SELF); ?>" METHOD=POST>
<P>Enter Screenshot URL

BR>
<TEXTAREA NAME="screenurl" ROWS=2 COLS=45 WRAP>
</TEXTAREA>

<FORM ACTION="<?php echo(PHP_SELF); ?>" METHOD=POST>
<P>Enter Download URL

BR>
<TEXTAREA NAME="downloadurl" ROWS=2 COLS=45 WRAP>
</TEXTAREA>

<FORM ACTION="<?php echo(PHP_SELF); ?>" METHOD=POST>
<P>Enter License Info

BR>
<TEXTAREA NAME="licenseinfo" ROWS=5 COLS=45 WRAP>
</TEXTAREA>

<FORM ACTION="<?php echo(PHP_SELF); ?>" METHOD=POST>
<P>Enter System Requirements

BR>
<TEXTAREA NAME="systemreq" ROWS=5 COLS=45 WRAP>
</TEXTAREA>

<P>Author:
<SELECT NAME="aid" SIZE=1>
<OPTION SELECTED VALUE="">Select One
<OPTION VALUE="">---------
<?php
while ($author = mysql_fetch_array($authors)) {
$aid = $author["ID"];
$name = $author["Name"];
echo("<OPTION VALUE='$aid'>$aname\n");
}
?>
</SELECT></P>

<P>License:
<SELECT NAME="lid" SIZE=1>
<OPTION SELECTED VALUE="">Select One
<OPTION VALUE="">---------
<?php
while ($license = mysql_fetch_array($licences)) {
$lid = $license["ID"];
$name = $license["Name"];
echo("<OPTION VALUE='$lid'>$lname\n");
}
?>
</SELECT></P>

<P>Rating:
<SELECT NAME="rid" SIZE=1>
<OPTION SELECTED VALUE="">Select One
<OPTION VALUE="">---------
<?php
while ($rating = mysql_fetch_array($ratings)) {
$rid = $rating["ID"];
$name = $rating["Name"];
echo("<OPTION VALUE='$rid'>$rname\n");
}
?>
</SELECT></P>

<P>Category:
<SELECT NAME="cid" SIZE=1>
<OPTION SELECTED VALUE="">Select One
<OPTION VALUE="">---------
<?php
while ($cat = mysql_fetch_array($cats)) {
$cid = $cat["ID"];
$name = $cat["Name"];
echo("<OPTION VALUE='$cid'>$cname\n");
}
?>

<?php

if ($submit):

if ($aid == "") {
echo("<P>You must choose an author.</P>");
exit();
}

if ($lid == "") {
echo("<P>You must choose a license.</P>");
exit();
}

if ($rid == "") {
echo("<P>You must choose a rating.</P>");
exit();
}

if ($cid == "") {
echo("<P>You must choose a category.</P>");
exit();
}

$dbcnx = @mysql_connect(
"localhost", "audiomelody", "Bollinger");
mysql_select_db("audiomelody");

$sql = "INSERT INTO Reviews SET " .
"Title='$title', " .
"Versio='$version', " .
"ReviewText='$reviewtext', " .
"Date='CURDATE()', " .
"FileSize='$filesize', " .
"ScreenURL='$screenurl', " .
"DownloadURL='$downloadurl', " .
"LicenseInfo='$licenseinfo', " .
"SystemReq='$systemreq', " .
"AID='$aid', " .
"LID='$lid', " .
"RID='$rid', " .
"CID='$cid'," ;
if (mysql_query($sql)) {
echo("<P>New review added.");
} else {
echo("<P>Error adding new review: " .
mysql_error() . "</P>");
}
?>

</P>
<P><INPUT TYPE=SUBMIT NAME="submit" VALUE="SUBMIT"></P>
</FORM>
<?php endif; ?>
</BODY>
</HTML>

I then get the error message:

Parse error: parse error in c:\program files\apache group\apache\htdocs\addreview5.php on line 218

Which I find odd, as that line only says : </HTML>

I would appreciate all the help I can get,

Cheers (thanks in advance)

Tim

**Renegade** · Oct 25, 2001 17:10

A couple things that might help you out

1) Make only one form. Meaning, use only one <form> tag. Instead of a <form> tag for each form element.

2) you have "if submit" in two places. YOu only need them in one place. (usually at the top)

If you get a parse error on the last line of your script, and it is not PHP code, then look up until you DO reach a line of PHP code:

<?php endif; ?>

I don't believe there is an endif; statement. You should probably just have a closing } instead.

good luck

**Defender1** · Oct 25, 2001 20:50

you have 2 lines with if($submit): and one else: and only one endif;
also, i'd recommend just using

PHP Code:


if(condition)

{

  //do stuff

}

else

{

  //do stuff

}

for your ifs. or at least pick a constant.

**masm50** · Oct 26, 2001 01:58

I noticed the double if statement about 10 mins after I posted - I should have edited my post I suppose.

Thanks for the other tips though,

see how I go,

Cheers

Tim

User Tag List

Thread: I can't fiind what is wrong with this PHP script, any ideas?

Thread Tools

Display

I can't fiind what is wrong with this PHP script, any ideas?

Thanks guys

Bookmarks

Bookmarks

Posting Permissions