help with ASP code

[marie70]

Hello, this code doesn't send the mail, can you see the problem?
Our test sends the message:
503 must have sender and recipient first


Set Mailer = Server.CreateObject("SMTPsvg.Mailer")
Mailer.FromName = ""& Request("Name") &""
Mailer.FromAddress = ""& Request("Email") &""
Mailer.AddRecipient "Upper Village Market Customer Order", "marie@that70sgirl.com"
strMailHost = "mail.webrothers.com"
Mailer.RemoteHost = strMailHost


Mailer.ReturnReceipt = false
Mailer.ConfirmRead = false

Mailer.Subject = "**CUSTOMER ORDER**"

and then the message blah blah blah

Mailer.Timeout = 30
Mailer.SendMail

here is our little test that returned the message above:

rem SendMail returns a true or false
rem test for Send Mail
if Mailer.SendMail then
Response.Write "Mail sent..."
else
Response.Write "Error<br>"
Response.Write Mailer.Response
end if

Thanks in advance
Marie

[goober]

Here's the code that should work:

[code]Set Mailer = Server.CreateObject("SMTPsvg.Mailer")
Mailer.FromName = Request("Name")
Mailer.FromAddress = Request("Email")
Mailer.AddRecipient "Upper Village Market Customer Order", "marie@that70sgirl.com"
strMailHost = "mail.webrothers.com"
Mailer.RemoteHost = strMailHost


Mailer.ReturnReceipt = false
Mailer.ConfirmRead = false

Mailer.Subject = "**CUSTOMER ORDER**"

and then the message blah blah blah (<--supposed to be there?)

Mailer.Timeout = 30
Mailer.SendMail

here is our little test that returned the message above:
if Mailer.SendMail then
Response.Write "Mail sent..."
else
Response.Write "Error<br>"
Response.Write Mailer.Response
end if

Thanks in advance
Marie


Last edited by marie70 on 02-Oct-2001 at 01

[marie70]

Thanks for replying, no that red code isn't supposed to be there, I just have a lot of other stuff in there (the blah blah blah). I tried making the changes you suggested, but it still seems to work the same way because I still get the message:
503 must have sender and recipient first

Any other thoughts?

[KodeKrash]

Avoid using Request(), use Request.QueryString() or Request.Form() as needed. Also, make sure you have the AddRecipient parameters in the correct order, most email COMs use the following syntax:

Mailer.AddRecipient( strEmail, strName )

Try this code and see what it does for you (assuming your mailer is using the form POST method).

Set Mailer = Server.CreateObject( "SMTPsvg.Mailer" )
Mailer.FromName = Request.Form( "Name" )
Mailer.FromAddress = Request.Form( "Email" )
Mailer.AddRecipient "Upper Village Market Customer Order", "marie@that70sgirl.com" 
Mailer.RemoteHost = "mail.webrothers.com"
Mailer.ReturnReceipt = False 
Mailer.ConfirmRead = False 
Mailer.TimeOut = 30
Mailer.Subject = "** Customer Order **"
Response.Write( Mailer.SendMail )

<sidenote>In the code you posted, you are actually sending
the email twice, as you call Mailer.SendMail 2 times, once
to send and once to check for errors.</sidenote>

[dhtmlgod]

Originally posted by marie70
""& Request("Name") &""

Where is this coming from?! I've seen it a few times here at SitePoint? Is is from a book?

[Jeremy W.]

Request is a collection, and .cookies and .form and .querystring are sub collections...

So you can just look in all collections if you so desire but it's both inefficient and sloppy.

I THINK, but I'm not sure

btw, way to go on the How Do YOU threads, keep up the work and participation will increase, don't get discouraged If we have like NO replies after a month we'll stop it

[dhtmlgod]

Ok, so I made myself look like an idiot,

What i was talking about was the ' "" & '

Sunny, the request("blah") is ok, its not really sloppy or inefficient, just that it leave it open to causing errors. Mainly it could request it from the wrong thing, ie, form instead of cookie, etc. etc.

the Request is called an object, binaryRead is called a method, totalBytes is a property and clientcertificate, cookies, form, querystring, and servervariables are called collections.

Just thought I'd clear that up for you

[Jeremy W.]

Cleared up

"its not really sloppy or inefficient, just that it leave it open to causing errors"

That's sloppy and inefficient to me

[dhtmlgod]

Well, whatever you do, don't look too closely at the search scripts I've supplied you with, lol

[KodeKrash]

By restricting the form method, you can also keep lamers from using your scripts for things that they were not intended for, particuarly mail scripts. By forcing the POST method, you eliminate 1/2 the lamers because they don't understand the way HTTP works, and don't know how to spoof headers. The sad part about this is that most web "developers" don't have a clue about the protocols they use either. Most of my form handling scripts will require POST and log any attempts made to use GET, and if the user persists in using GET, they are banned (by IP) from the server.

<mischief>I just LOVE finding unprotected mailer scripts. It gives me
great pleasure to teach people a lesson by putting their server on it's knees.</mischief>

[dhtmlgod]

Lol kode, I think you'ev got too much free time on your hands

[KodeKrash]

LOL, free time??? AS IF!

I just copy/paste the URL for the script in my little application and hit the "BOMB!" button. It will keep sending until A) the server doesn't respond, or B) I turn it off.

The whole process takes me an entire 5 seconds, after that, I turn around back to my workstation and get back to work.

Sure, it is overkill, but you can understand my point, I am sure. I do it to help server admins learn a lesson, not too harm the server. Other people may not be so nice. For example, the 9 people that are CONSTANTLY trying to DoS my mail servers. Too bad all they get from my servers is "Connection DENY on port 25". All the lamers have succeeded in doing is filling up my security logs a little faster.

[marie70]

I used Request.Cookies instead of just Request. It didn't seem to make any difference. I'm not sure which goes first in Mailer.AddRecipient, first you said try the e-mail first, but your code has it second? Neither works in any case. With the
Response.Write( Mailer.SendMail )
at the end it goes to a new page and says FALSE.

Any other suggestions would be GREATLY appreciated!

Thanks so much

[KodeKrash]

Have you tried any other Email components ?

You might try MailMonger as it will tell you what email COMs your server supports.

[marie70]

OKey Dokey I'll check it out, thanks

[goober]

hmm, better yet, try CDONTS, since it should be installed by default on your server (if it is NT). If not, well then your host has a problem...so easy to use and easy to install on the server.

and D' wrote a tutorial on it. Which rocks. I just have to make it 'sitepointable'.

(PS D', i need that tutorial again! PM plaintext works really well, i'll take care of the formatting.)

Hope you'll consider CDONTS.

[KodeKrash]

MailMonger supports CDONTS (and 9 other major email COMs), and it has a function to tell you which one IS installed on the server. If you ever move the site to a host that doesn't support the email component you setup in your MailMonger controller, you just change it by setting objMail.Provider = xx, you don't have to go chase down all the different places you have mailer functions.

[marie70]

alright, I tried the MailMonger and I do have CDONTS on this server, do I only have to change this line of code then?
Set Mailer = Server.CreateObject("SMTPsvg.Mailer")

Or should I wait for that tutorial?

Thanks again

[dhtmlgod]

The CDONTS tutorial? If you look at my signature, there is a link

[marie70]

OH well that IS handy, thanks you are a super peach!

[KodeKrash]

It sounds like you have it wrapped up with CDONTS, so I will shut up about MailMonger.

[jet_wang]

About CDONTS, how we specify the sender's name or recipient's name ? As far as I know, CONTS only use sender's email and recipient's email.

[dhtmlgod]

I guess I should have added that into the tutorial, it would look like this:

objEmail.to = """Chris Canal"" <dhtmlgod@hotmail.con>"
objDmail.From = """Joe Smith"" <joe@blahblah.com>"

[goober]

Revisions are an excellent Idea, D'.

[jet_wang]

I'm using ASP for CDONTS, so usually I do thing like this :
fname = Request("fname")
femail = Request("femail")
tname = Request("tname")
temail = Request("temail")

objMail.To = temail
objMail.From = femail

Last time I try this :
objMail.To = tname & temail
objMail.From = fname & femail

There is no error, but no message was sent.
Can you explain to me, why there are many " and before email address, is there must be a space ?