Variable naming convention for multiple SQL-queries: best practice?

[spinmaster]

Hi,

I have certain functions where I need to execute multiple SQL-queries right
after each other within a single function (INSERT, SELECT, UPDATE).

I'd like to hear the best coding practice in terms of variable names
for the queries. I want to avoid something like this:

function doSomething() {

// insert query
$sql1 = "INSERT something";
$result1 = $db->query($sql1);

// select query
$sql2 = "SELECT something"; 
$result2 = $db->query($sql2);

// update query
$sql3 = "UPDATE something";
$result3 = $db->query($sql3)
} 

Giving each variable inside the function a name like "$sqlInsertUser" and "$resultInsertUser" makes the code also not really readable...

someone who can give some input??

[Jelena]

To tell the truth I would go with

function doSomething() {

// insert query
$sql = "INSERT something";
$result = $db->query($sql);

// select query
$sql = "SELECT something";
$result = $db->query($sql);

// update query
$sql = "UPDATE something";
$result = $db->query($sql)
} 

[L4suicide]

what if he needs to use a query multiple times?

i prefer to use memorable things:
$update_sql
$userupdatesql
etc

So i know im using the right one (i dont see how it makes it look ugly)

[kyberfabrikken]

Giving each variable inside the function a name like "$sqlInsertUser" and "$resultInsertUser" makes the code also not really readable...

What's wrong with $sqlInsertUser ? I'd use that.

[stereofrog]

$result1 = $db->query("INSERT something");
$result2 = $db->query("SELECT something");
$result3 = $db->query("UPDATE something") 

[Toly]

On another note, you don't really need to be assigning $result variables for INSERT/UPDATE queries since they won't be returning anything anyways.

[spinmaster]

Thx for the replies...

On another note, you don't really need to be assigning $result variables for INSERT/UPDATE queries since they won't be returning anything anyways.

Normally, you're right... but I'm using PEAR-DB and the $result variable is useful to check if the query was successfull:

$result = $db->query("INSERT INTO table VALUES ($id, sitepoint, forum)");
if (DB::isError($result)) {
    die($result->getMessage());
} 

[Hero Doug]

I use arrays myself.

function doSomething() { 

// insert query 
$sql['insert'] = "INSERT something"; 
$result['insert'] = $db->query($sql); 

// select query 
$sql['select'] = "SELECT something"; 
$result['select'] = $db->query($sql); 

// update query 
$sql['update'] = "UPDATE something"; 
$result['update'] = $db->query($sql) 
}

That way if you have multiple queries on one page it makes it easy to remember what queries are for what purpose. You can essentially use the same name for them but still give them distinct unqiueness.

[spinmaster]

I use arrays myself.

function doSomething() { 

// insert query 
$sql['insert'] = "INSERT something"; 
$result['insert'] = $db->query($sql); 

// select query 
$sql['select'] = "SELECT something"; 
$result['select'] = $db->query($sql); 

// update query 
$sql['update'] = "UPDATE something"; 
$result['update'] = $db->query($sql) 
}

Hey, for me that seems to be the best solution! Thx for that hint!

[Hero Doug]

glad to help