Can someone find the bug in this script??

[luchazard]

Here it is:

<?

// check for first & last name

if ($first_name==""||$last_name=="") {

echo("You need to provide your first & last name!");

}

// check for sender's email

if ($from_email=="") {

echo("You need to provide your email address!");

}

// check for at least one recipiant email

if ($to_email=="") {

echo("You need to provide at least one recipiant email address!");

}

// validate sender's email

if (!eregi("^[-a-z0-9\._]+@[-a-z0-9\._]+\.+[a-z]{2,3}$", $from_email)) {

echo("You provided a improper email address!");

}

// validate recipiant email addresses

if (!eregi("^[-a-z0-9\._]+@[-a-z0-9\._]+\.+[a-z]{2,3}$", $to_email)) {

echo("You provided a improper email address!");

}

// the message

mail($to_email, Hello, How are 'ya?)

?>

You call it here: http://www.crazedhumor.com/taf.htm

I can't find out what I did wrong!!! It won't mail the message...

thanks in advance!

[jogler]

You should probably put quotations around Hello and How are you in the subject and message fields, respectively, also, a semi-colon at the end would help, like so:

mail($to_email,"Hello","How are 'ya?");

HTH
jogler

[luchazard]

Thanks Jogler, I'll try that now!

[tubedogg]

Actually both things jogler mentioned are required.

[Defender1]

mail("to_field", "subject_field", "message_body", "From: from_who"); 

that's the proper usage of mail()

[seanf]

Originally posted by Defender1

mail("to_field", "subject_field", "message_body", "From: from_who"); 

that's the proper usage of mail()

You don't have to include from, it is just there if you want to send a different address instead of your default one from the mail server

Sean

[freakysid]

bool mail (string to, string subject, string message [, string additional_headers [, string additional_parameters]])

As Sean suggests, the third and forth arguements are optional. I just wanted to add that the forthe arguement is actually for additional headers. So people often forget that this can included a Bcc header where you can list additional recipients to be sent a copy without their address being revealed to other recipients.

I don't know how many email addresses you can legally fit into a Bcc: header but this is they way I would do a mail out to a list using php and mail() rather than looping through lots of calls to mail() to send the mail to each recipient individually. The trick here is to make sure the email address in your "to" arguement is your email address (something like: mail-list@mydomain.com) so that that is the only address that is revealed to all your mailing list members (not some other poor member's email address).

[Defender1]

oops yea, i forgot to mention it.
but it's usually a good idea to include who the mail is from though