Whats wrong with this code?

[kunal]

Could someone tell me whats wrong with this code? It doesnt seem to be working and isnt poping up any error either

<?
    function getLinks($url) {
        if(!$url) {
            return "Error opening $url";
            }
        else {
            $url = eregi_replace("http://", "", $url);
            $fp = fsockopen("$url", 80, &$errorstr, &$errorno, 30) or DIE("could not connect $errorstr
($errorno)");
            fputs ($fp, "GET / HTTP/1.0\r\n\r\n");
                if($fp) {
                    while(!feof($fp)) {
                        $data .= fgets($fp, 4096);
                                        }
                    fclose($fp);
                        }
                else {
                    return "Error opening $url";
                    }
            }
preg_match_all ("/<a[^>]*>(.+)<\/a>/imU", $data, $matches);
        $matches = $data;
        return $matches;
        }

    $links = getLinks("www.yahoo.com");
    for ($i=0;$i<count($links);$i++) {
                echo "$links[$i]<br>";
                                        }

?>

[freddydoesphp]

What isn't working with it. I just tested it and it showed me links from yahoo's website. Is there a specific part that isn't working.

[delemtri]

Try $link="$links[$i]<br>"; echo "$link"; at the end. I've had problems with trying to echo() array elements before.

[kunal]

it only shows me an "H" and nothng else

[freddydoesphp]

Now I know you changed some stuff around in your code from the original. I know since I wrote it and it looks different from what you have here. Anyways, not sure where or why the changes were made but it should look like this.

<?
    function getLinks($url) {
        if(!$url) {
            return "Error opening $url";
            }
        else {
            $url = eregi_replace("http://", "", $url);
            $fp = fsockopen("$url", 80, &$errorstr, &$errorno, 30) or DIE("could not connect $errorstr
($errorno)");
            fputs ($fp, "GET / HTTP/1.0\r\n\r\n");
                if($fp) {
                    while(!feof($fp)) {
                        $data .= fgets($fp, 4096);
                                        }
                    fclose($fp);
                        }
                else {
                    return "Error opening $url";
                    }
            }
preg_match_all ("/((<a[^>]+>)([^<]+)(<\/a>))/i", $data, $matches);
        return $matches[0];
        }

    $links = getLinks("www.yahoo.com");
    for ($i=0;$i<count($links);$i++) {
                echo htmlspecialchars($links[$i])."<br>";
                                        }
?>

[kunal]

yea.. its the code you gave me

I just changed the for loop and the preg_match_all code.. thats about it..


hmm.. your code deosnt output anything for me

All i wanna do is show everything in the <a> </a> tags..

[freddydoesphp]

This is not the code I gave you

preg_match_all ("/<a[^>]*>(.+)</a>/imU", $data, $matches);
        $matches = $data;

Anyways, not sure why it isn't working for you here it is working as prescribed.

Working Example
http://www.irq11.com/freddy/preg_match_all.php

Source Code for working example
http://www.irq11.com/freddy/preg_match_all.phps

[kunal]

man.. this is unbelievable... now this code is working.. all i did was copy the code from the link you gave me.. made a couple of changes.. and boom.. its working fine


well thanks a lot for the help