Newbie problem with readdir() providing blank file names

[Micand]

Hello. I recently started learning PHP. One of my first tasks has been to write a simple script that obtains the filenames of several files in a subdirectory and then prints them. (I am building up to a script that shall output the HTML necessary to display a page of thumbnails which link to full-sized photos.) My script's source is as follows:

$imageDir = ImageList ("screens/small");

for ($i = 0; $i < count ($imageDir); $i++) {
    printf ("%s<BR>\n", $imageDir[i]);
}

function ImageList ($sPath) {
    //Load Directory Into Array
    $imageList = array();
    $handle = opendir ($sPath);

    while ($file = readdir($handle)) {
        if ($file != "." && $file != "..") {
            array_push ($imageList, "$file");
        }
    }

    //Clean up and sort
    closedir ($handle);     
    sort ($imageList);
    return $imageList;
} 

The output from this script is composed only of the <BR> and \n statements; it simply does not output any file names. I shall appreciate any assistance that you can provide. Thanks in advance.

[freddydoesphp]

I couldn't figure out what was wrong with your code so I just rewrote it a bit and now it should work.

$imageDir = ImageList(".");

foreach($imageDir as $key => $val) {
    print "$val<br>\n";
    }

function ImageList($sPath) {
    $d = dir($sPath);
    while ($file = $d->read()) {
        if (($file != ".") && ($file != "..")) {
            $imageList[] = $file;
            }
        }
    //Clean up and sort
    $d->close();     
    sort($imageList);
    return $imageList;
    } 

[Micand]

Thanks for the quick reply. I copied and pasted your code exactly as it appears. When executed, the script generates a "parse error" on line 8 (the line with the "foreach" statement). I tried it on two separate hosts with PHP support (Hobbiton and F2s); one was running PHP 4.0.5, the other 4.0.6RC3. Both generated the same error. I shall appreciate any additional help you may be able to provide. Thanks again.

[freddydoesphp]

Okay you must bot have support for foreach() or something although I though anything newer than 4.0.4 had it. anyways try changing

foreach($imageDir as $key => $val) {
    print "$val<br>\n";
    } 

to

for ($i=0;$i<count($imageDir);$i++)  {
    print $imageDir[$i]."<br>\n";
    } 

If this still produces a parse error could you please copy and paste the exact code you are using here.

[freddydoesphp]

Incidently I think the reason your first attempt failed, was this line

printf ("%s<BR>\n", $imageDir[i]); 

Should have been

printf ("%s<BR>\n", $imageDir[$i]); 

Noctie the misssing $ sign before i in yours.

[Micand]

After changing the foreach statement to a for loop, I continue to get a parse error. This time, it states that there was a parse error on the line that reads as follows: "for*($i=0;$i<count($imageDir);$i++)**{".

You were correct in pointing the error in my original code. Everything works perfectly now that a '$' precedes the 'i'. Although the code that you provided me with doesn't function correctly (no idea why), the original code is fine, thanks to your pointing out my error. Thanks for all your help.