Why won't this While Loop terminate?

[gregor002]

I suppose the title of the thread says it all. Am I missing something here??

function getTop10($connection) {
    $sql = "SELECT DISTINCT(track_page) FROM site_stats ORDER BY track_page DESC LIMIT 1, 10";
    if(!$result = mysql_query($sql,$connection)) {
        echo "Error 002: Top 10 Pages are unavailable at this time";
    } else {
        $topPages = mysql_fetch_array($result);
        $i = 1;                
        while($i < 11) {    
            echo $topPages['track_page'] . "<br />\n";
        }                                                                                    
    }//end else                        
} //end function 

[djones]

You are not incrementing $i inside the loop. You set it at 1 and never change it.

[thirteenlisk]

$i never changes in value... it always has the value of one.

Try this:

while($i < 11) {     
             echo $topPages['track_page'] . "<br />\n";
              $i++;
          } 

</font></font>

[shref]

you forgot something

while($i < 11) {     
            echo $topPages['track_page'] . "<br />\n"; 
         $i++ ;
        } 

[gregor002]

Thanks guys ... it's 42 celcius in Toronto today ... heat must be getting to me.

[djones]

Be careful. What happens if your query returns less than 10 rows? Would you not be better using the following type of thing?

while ($row = mysql_fetch_array($result))
{
...
}

[shref]

hehe, you are lucky three answers in one minute