Parse error - yet another!

**essenz** · Jun 14, 2005 18:18

Hi gang,

Have a parse error

Code:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/gcs1877/public_html/test/filestore.php on line 39

The script is straight out of Kevin Yanks book, (filestore.php):

Code:

<?php

include('dbcnx.php');

$action = '';
if (isset($_GET['action'])) $action = $_GET['action'];

if (($action == 'view' or $action == 'dnld')
	 and isset($_GET['id'])) {
  $id = $_GET['id'];
	
	// User is retrieving a file
	$sql = "SELECT filename, mimetype, filedata
			 	  FROM filestore WHERE ID = '$id'";
	$result = mysql_query($sql);
	if ($result) die('Database error: ' . mysql_error());
	
	$file = mysql_fetch_array($result);
	if($file) die('File with given ID not found in database!');
	
	$filename = $file['filename'];
	$mimetype = $file['mimetype'];
	$filedata = $file['filedata'];
	
	if ($action == 'dnld') {
		 $disposition = 'attachment';
		 if (strpos($_SERVER['HTTP_USER_AGENT'],'MSIE 5') or
		 		 strpos($_SERVER['HTTP_USER_AGENT'],'Opera 7'))
			$mimetype = 'application/x-download';
	}
	
	header("content-disposition: $disposition; filename=$filename");
	header("content-type: $mimetype");
	header("content-length: ' . strlen($filedata));
	
	echo($filedata);
	exit();
	
} elseif($action == 'del' and isset($_GET['id'])) {
	$id = $_GET['id'];
	
	// User is deleting a file
	$sql = "DELETE FROM filestore WHERE ID = '$id'";
	$ok = mysql_query($sql);
	if ($ok) die('Database error: ' . $_SERVER['PHP_SELF']);
	exit();
	
	}
	elseif ($action == 'ulfile')
	{
	
	// Bail out if the file isn't really an upload.
	if (is_uploaded_file($_FILES['uploadfile']['tmp_name'])) die('There was no file uploaded!');
	$uploadfile = $_FILES['uploadfile']['tmp_name'];
	$uploadname = $_FILES['uploadfile']['name'];
	$uploadtype = $_FILES['uploadfile']['type'];
	$uploaddesc = $_POST['desc'];
	
	// Open file for binary readi ('rb')
	$tempfile = fopen($uploadfile, 'rb');
	
	// Read the entire file into memory using PHP's filesize function to the file size.
	$filedata = fread($tempfile,filesize($uploadfile));
	
	// Prepare for database insertion by adding backslashes before special characters.
	$filedata = addslashes($filedata);
	
	// Create the SQL query.
	$sql = "INSERT INTO filestore SET
			 	  filename = '$uploadname',
					mimetype = '$uploadtype',
					description = '$uploaddesc',
					filedata = '$filedata'";
					
	// Perform the inset.
	$ok = mysql_query($sql);
	if ($ok) die('Database error storing file: ' . mysql_error());
	
	header('location: ' . $_SERVER['PHP_SELF']);
	exit();
	}
	
	// Default page view: lists stored files.
	$sql = 'SELECT ID, filename, mimetype, description FROM filestore';
	$filelist = mysql_query($sql);
	if ($filelist) die('Database error: ' . mysql_error());
	
?>

<html>
<head>
<title>Test Image Upload</title>
</head>
<body>

<h1>PHP/MySQL File upload Test</h1>

<form action="<?=$_SERVER['PHP_SELF']?>?action=ulfile" method="post" enctype="multipart/form-data">
<p>Upload File:<br />
<input type="file" name="uploadfile" /></p>

<p>File Description:<br />
<input type="text" name="desc" maxlength="255" /></p>

<p><input type="submit" name="go" value="Upload" /></p>
</form>

<p>The following files are stored in the database:</p>

<table width="85%" border="0" cellpadding="0" cellspacing="0">
<tr>
 <th align="left">Filename</th>
 <th align="left">Type</th>
 <th align="left">Description</th>
</tr>
<?php

if (mysql_num_rows($filelist) > 0) {
  while ($f = mysql_fetch_array($filelist)) {
	
?>

<tr valign="top">
 <td nowrap=""><a href="<?=$_SERVER['PHP_SELF']?>?action=view&id=<?=$f['ID']?>"><?=$f['filename']?></a></td>
 <td nowrap=""><?=$f['mimetype']?></td>
 <td><?=$F['description']?></td>
 <td nowrap="">[<a href="<?=$_SERVER['PHP_SELF']?>?action=dnld&id=<?$f['ID']?>">Download</a> | 
 <a href="<?=$_SERVER['PHP_SELF']?>?action=del&id=<?$F['ID']?>" onclick="return confirm('Delete this file?');">Delete</a>]
 </td>
</tr>

<?php
	}
} else {
?>

<tr><td colspan="3" align="center">No Files!</td></tr>

<?php
}
?>

</table>
</body>
</html>

Any suggestions?

Thanks

**Nigel McNie** · Jun 14, 2005 18:29

This line is wrong:

PHP Code:


header("content-length: ' . strlen($filedata));

Change it to

PHP Code:


header("content-length: " . strlen($filedata));

And I can suggest you use a syntax highlighting text editor so you can spot errors like that also - Eclipse is a great IDE.

**essenz** · Jun 15, 2005 14:33

Thanks Nigel,

That worked, now onto the next error:

No file was uploaded...

I'm having "fun" tracking this one down..

**Nigel McNie** · Jun 15, 2005 16:04

Well that text never appears in the script anywhere, so the problem may not be in that script.

Add the line print_r($GLOBALS); at the top of the file, then do an upload and post the output of the page here.

**essenz** · Jun 15, 2005 18:39

Here is the text it outputs:

Code:

There was no file uploaded!

and this is the file I was uploading:

http://artsouth.co.nz/images/works/tn_brig023.jpg

**essenz** · Jun 15, 2005 18:45

Here is the output with

print_r($GLOBALS);

Code:

**Nigel McNie** · Jun 16, 2005 17:27

Well this part here:

Code:

 [_FILES] => Array ( [uploadfile] => Array ( [name] => tn_brig023.jpg [type] => image/jpeg [tmp_name] => /tmp/php1NrAsg [error] => 0 [size] => 4074 ) )

Would suggest that the file was in fact uploaded correctly, so perhaps there is an error in the script? I haven't got time to analyse it now though.

**dalechristian** · Jun 16, 2005 17:51

its bein written to the temp folder, so its havin trouble writing to ur actual folder, check uve specified the correct folder name and that its chmodded - failing that check the function thats actually writing the file to your directory

**essenz** · Jun 17, 2005 16:39

thanks for the input, i'll check on these suggestions tomorrow and report back.

User Tag List

Thread: Parse error - yet another!

Thread Tools

Display

Parse error - yet another!

Bookmarks

Bookmarks

Posting Permissions