can't write to database?

[london]

So I wrote a tiny bit of PHP script to write to my database, looking like this:

<?
if ($signup == go) {
MYSQL_CONNECT(localhost, shh, xxxxx) OR DIE("Unable to connect to database");

@mysql_select_db("shh") or die("Unable to select database");

$query = "INSERT INTO users VALUES('$username','$password')";
$result = MYSQL_QUERY($query);

echo ("Thank you:" . $username . "and" . $password . "have been added to the database.");

MYSQL_CLOSE();
} else {
echo ("<form action=" . $PHP_SELF . " method=get>username: <input type=text name=username><br>password: <input type=text name=password><br><input type=submit name=signup value=go>");
}
?>

I've also tried it in various other forms, and none have worked. My table, "users" is setup, with the fields "UID" (primary integer, auto_increment) "username" (text) and "password" (text).

The script, when run, returns that the values have been added, but when I check on the database, it's empty.

Can anyone explain where I've gone wrong?

[manipura]

Change this:

$query = "INSERT INTO users VALUES('$username','$password')";
$result = MYSQL_QUERY($query);

To This:

$query = "INSERT INTO users (username,password) VALUES('$username','$password')";
$result = MYSQL_QUERY($query)or die("Something Bummed out");

Then run it. See what happens

[london]

thank you! it now works like a charm!