Isset

[ucahg]

Can anyone tell me why this doesn't work?

<?php IF(!IsSet($admin)) { print("<a href=\"login.php\" onMouseOver=\"window.status='';return true\" onMouseOut=\"window.status='';return true\">"); } ?><FONT size="1" color="#1D2868">5</FONT><?php IF(!IsSet($admin)) { print("</a>"); } ?>

I need it so if someone is logged in, it won't show that. I already have it so that ?admin will be next to the url after someone is logged in, so $admin should exist, but it doesn't.

[qslack]

If you want it to show that if an admin is logged in, then remove the ! from IF(!IsSet($admin)). Also, it would be better IMO to just use ?admin=1 and then if($admin) instead of ?admin and what you current have.

You should definitely check for authorization even if ?admin=1 is appended to the URL--nothing is stopping anyone from just adding that and gaining admin access.

[ucahg]

okay thanks.

I am going to check, but I was planning on only running sessions if the admin variable is there, so it doesn't slow down most people. I'm not sure if it would be worth it though. Would sessions slow the site down at all?

[Anarchos]

Jesus christ that is ugly code.

1. Put it on multiple lines.

2.The if statement braces can span HTML tags, so you don't need two if statements.

3. Keep HTML and PHP lowercase.

[ucahg]

the capital letters are because I copied that code from php.net to make sure I wasn't doing anything wrong.

anyone know whether sessions makes a big speed difference

[qslack]

On all but the most highly-trafficked sites, sessions won't make a noticeable speed different.