how do I get rid of: notice error

**zerakh** · Apr 4, 2005 18:04

Just curious as to why I'm getting an error on this page....
I've never had one before but now it started up and I cant seem to get rid of this error::

Notice: Undefined offset: 3 in **DIR**webroot\links.php on line 30

<?php

$display = 10;

if ( $handle = opendir("./Discussion/links/") )
{
while ( ( $file = readdir( $handle ) ) !== false )
{
if ( $file != "." && $file != ".." )
{
$news_array[] = $file;
}
}
closedir( $handle );
}

array_multisort( $news_array, SORT_NUMERIC, SORT_DESC );
array_splice( $news_array, $display );

$num_news = ( count( $news_array ) );

foreach ( $news_array as $val )
{
$news_file = file("./discussion/links/$val");

$date = $news_file[0];
$author = $news_file[1];
$texts = $news_file[2];
$links = $news_file[3];
$link = "$links";
$text = stripslashes($texts);
$needle = "http://";
$check = strpos($link, $needle);

if($check === false)
{
//if "http://" is not present in $link, prepend it yourself
$correctLink = "http://" . $link;
}
else
{
//the given link was okay
$correctLink = $link;
}

echo "".$date." ";
echo 'Written by: '.$author.' ';
print "<a href=\"" . $correctLink . "\"><body vlink='yellow'>" . $correctLink . "</a> ";
print " &nbsp - ";
echo $text;
echo ' <body vlink="#BABABA"><a href="#beginning">Top</a> ';
}

?>

**markl999** · Apr 4, 2005 18:12

It's a NOTICE not strictly an error, caused by:
$links = $news_file[3];
It means that there is no 4th element in the $news_file array.

Yoiu can either fix it (preffered) or hide the notice by putting error_reporting(0); at the top of your script

**defiance** · Apr 4, 2005 18:12

if($check === false)

you have 3 =

change it to only 2

-----------------------------------
print " &nbsp - ";

yuo forgot semilcolon on the second nbsp

and try echoing out

print_r($news_file);

and see if you have 4th element coz you are trying to echo
$links = $news_file[3];

**markl999** · Apr 4, 2005 18:14

if($check === false)
you have 3 =
change it to only 2

3 ='s are ok and quite correct in this case

**zerakh** · Apr 4, 2005 18:16

thanks- I just went back in and noticed that there wasnt anything listed for that link.

how would I go about fixing this if nothing is placed within that particular location?

I would guess using the trim function?

$link= trim($link);
if(!empty($link))
{
echo $link;

}

**markl999** · Apr 4, 2005 18:20

Maybe:

PHP Code:


$links = isset($news_file[3]) ? $news_file[3] ? '';

Further down you'll want:
if($check === false && !empty($link))

**defiance** · Apr 4, 2005 18:23

Originally Posted by markl999

3 ='s are ok and quite correct in this case

opps

sorry abt that.
thanks mark.

3 ='s is used to check for logic value?

**markl999** · Apr 4, 2005 18:24

== checks if the values match.
=== checks the value and the type match (int, string, bool etc..).

**defiance** · Apr 4, 2005 18:25

Originally Posted by markl999

== checks if the values match.
=== checks the value and the type match (int, string, bool etc..).

ermm
ic
thanks

**zerakh** · Apr 4, 2005 18:30

is this how I put it in?

<?php

$display = 10;

if ( $handle = opendir("./Discussion/links/") )
{
while ( ( $file = readdir( $handle ) ) !== false )
{
if ( $file != "." && $file != ".." )
{
$news_array[] = $file;
}
}
closedir( $handle );
}

array_multisort( $news_array, SORT_NUMERIC, SORT_DESC );
array_splice( $news_array, $display );

$num_news = ( count( $news_array ) );

foreach ( $news_array as $val )
{
$news_file = file("./discussion/links/$val");

$date = $news_file[0];
$author = $news_file[1];
$texts = $news_file[2];
$links = isset($news_file[3]) ? $news_file[3] ? '';
$text = stripslashes($texts);
$link = "$links";
$needle = "http://";
$check = strpos($link, $needle);

if($check === false && !empty($link))
{
//if "http://" is not present in $link, prepend it yourself
$correctLink = "http://" . $link;
}
else
{
//the given link was okay
$correctLink = $link;
}

echo "".$date." ";
echo 'Written by: '.$author.' ';
print "<a href=\"" . $correctLink . "\"><body vlink='yellow'>" . $correctLink . "</a> ";
print "   - ";
echo $text;
echo ' <body vlink="#BABABA"><a href="#beginning">Top</a> ';
}

?>

when I do this, I get::

Parse error: parse error, unexpected ';' in **DIR**\webroot\links.php on line 30

**markl999** · Apr 4, 2005 18:32

Sorry, my typo, i meant:
$links = isset($news_file[3]) ? $news_file[3] : '';

**zerakh** · Apr 4, 2005 18:35

that did it- thanks, I appreciate it

User Tag List

Thread: how do I get rid of: notice error

Thread Tools

Display

how do I get rid of: notice error

Bookmarks

Bookmarks

Posting Permissions