Synthax troubles

[ronnie98]

Hi all,
i have this code:

var popupSrc = document.getElementById("f_url").value;

var popupTitle = document.getElementById("poptitle").value;


html = "<a href=javascript:myPopImage(";

html += "'" + popupSrc + "',";

html += "'" + popupTitle + "'";

html += ")>";

where "f_url" and "poptitle" are text fields.
It should always output:

<a href=javascript:myPopImage('http://www.sampleurl.com/image.jpg','Popuptitle')">

but it stops working if the value of "poptitle" field is made of
more than one word,like:

<a href=javascript:myPopImage('http://www.sampleurl.com/image.jpg','My Popup Title')">

It seems that the space(s) between 2 or more words inside "poptitle" field
affects and breaks the synthax of the code producing stange outputs like:

<a href=javascript:myPopImage('http://www.sampleurl.com/image.jpg','My)">

so it truncates the value to the first word.
I need some help,of course.
Where i am wrong?
Thanks in advance,ralf.

[stereofrog]

I use the following simple function to avoid troubles when building long formatted strings in javascript:

function sprintf(format) {
	var args = sprintf.arguments, i = 1;
	return format.replace(/%s/g, function() {
		return args[i++];
	});
}

With this function your code looks much simpler:

html = sprintf(
	"<a href=javascript:myPopImage('%s', '%s')>", 
	popupSrc, 
	popupTitle);

hth...

[ronnie98]

Thank you,
i'll try and let you know.