Why does this not resize my photo uploads?

[Atealtha]

From an upload script, it moves the file to the appropriate directory and then resizes. The upload and moving is fine, but the script just does not resize it. I want it to make a jpeg file regardless of the file type uploaded.

function resize($width, $height, $quality, $filename) {
        // please fill out this form...
        list($srcw, $srch, $srct, $srca) = getimagesize($filename);
        // strip extensions
        $newFileName = preg_replace('/\.[gifjpn]{3}$/', '', $filename, 1);
        switch($srct)
        {
            // gif format
            case 1:
            $image = @imagecreatefromgif($filename);
            break;

            // jpg format
            case 2:
            $image = @imagecreatefromjpeg($filename);
            break;

            // png format
            case 3:
            $image = @imagecreatefrompng($filename);
            break;
        }
        $newImage = imagecreatetruecolor($width, $height);
        imagecopyresampled($newImage, $image, 0, 0, 0, 0, $width, $height, $srcw, $srch);
        return imagejpeg($newImage, $filename, $quality);
        imagedestroy($image);
        imagedestroy($newImage);
    } 

This is my first time working with image resizing. Any ideas why this might not be working as it should? BTW, this follows SitePoint's article on building a photo gallery script.

[St.]

script looks like good

maybe $width = $srcw and $height = $srch ?

and why you save resized image into $filename? maybe try saving into other file?

[Atealtha]

I want to replace the file. The original files are moved with chmod 0777.

I can echo all the $srcx variables. However lines like:
echo imagejpeg();
I do not get anything echoed out.

[St.]

It's stupid, but maybe browser caches your image? Did you check it?

[Atealtha]

No. I check the files via ftp and they're all the same size.

[swdev]

2 things I can see

• your calls to imagedestroy will never be called because of the return ... statement
  
• you create $newFileName but you never use it
  

Hope this helps