counting replies

[heigh]

hi there

i have functions below that used to count replies on specific thread/message

//funtion for pagination
function adminpagination()
{
$display = 10;
	
	
	if (isset($_GET['np'])) 
	{ 
		$num_pages = $_GET['np'];
	} 
	else 
	{ 
		$query = "SELECT * FROM posts"; 
		$query_result = mysql_query ($query);
		$num_records = @mysql_num_rows ($query_result);
		
		if ($num_records > $display) 
		{ 
			$num_pages = ceil ($num_records/$display);
		} 
		else 
		{
			$num_pages = 1;
		}
	}
	
	
	if (isset($_GET['s'])) 
	{ 
		$start = $_GET['s'];
	} 
	else 
	{
		$start = 0;
	}
			
	// Make the query.
	$query = "SELECT DATE_FORMAT(postupdate, '%M %D, %Y - %l:%i %p'), title, postID, firstname FROM posts AS p, users AS u
			WHERE p.userID = u.userID ORDER BY postupdate DESC LIMIT $start, $display";		
	$result = @mysql_query ($query); 
	$num = mysql_num_rows ($result); 
	
	if ($num > 0) 
	{ 	
		if ($num_pages > 1) 
		{			
			
			$current_page = ($start/$display) + 1;
			
			
			if ($current_page != 1) 
			{
				echo '<a href="report.php?s=' . ($start - $display) . 
				'&np=' . $num_pages . '" class=under>Previous</a> ';
			}
			
			
			for ($i = 1; $i <= $num_pages; $i++) 
			{
				if ($i != $current_page) 
				{
					echo '<a href="report.php?s=' . (($display * ($i - 1))) . 
					'&np=' . $num_pages . '" class=under>' . $i . '</a> ';
				} 
				else 
				{
					echo $i . ' ';
				}
			}
			
			
			if ($current_page != $num_pages) 
			{
				echo '<a href="report.php?s=' . ($start + $display) . 
				'&np=' . $num_pages . '" class=under>Next</a>';
			}
									
		} 
		
		
		echo "<tr align=center class=tablehead><td width=20% class=tableborder><table><tr><td><b>NAME</b></td></tr></table></td>
			<td width=50% class=tableborder><table><tr><td><b>TOPIC</b></td></tr></table></td>
			<td width=10% class=tableborder><table><tr><td><b>REPLIES</b></td></tr></table></td>
			<td width=20% class=tableborder><table><tr><td><b>DATE</b></td></tr></table></td></tr>";
		
		
		while ($row = mysql_fetch_array($result, MYSQL_NUM)) 
		{	
			//puta
								
			$row[0] = '<font size=1>'.$row[0].'</font>';
  			echo "<tr><td width=20% class=tableborder align=center><table><tr><td><b><a href=\"\" class=\"under\">".strtolower($row[3])."</a><b></td></tr></table></td>
			<td width=50% class=tableborder><table><tr><td><a href=\"reportview.php?pid={$row[2]}\" class=\"under\" style=\"font-weight: bold;\">$row[1]</a></td></tr></table></td>
			<td width=10% class=tableborder align=center><table><tr><td>".replies(floor($row[2]))."</td></tr></table></td>
			<td width=20% class=tableborder><table><tr><td>$row[0]</td></tr></table></td></tr>";  
			
		}		
	
		mysql_free_result ($result); 	
	
	} 
	else 
	{ 
		echo '<h3>There are no records to show.</h3>'; 
	}
	
	mysql_close(); 
}

//replies function
function replies($postID)
{
  $rcQuery = "SELECT count(postID) AS rowcount FROM comments WHERE postID=$postID";
  $rcResult = @mysql_query($rcQuery);
  if ($rcResult) 
  {
     return (@mysql_result($rcResult,0,'rowcount'));
  } 
  else 
  {
     die("Error with $rcQuery");
  }
}

the replies function is embedded in the adminpagination function...it worked fine though, but an error occured as follows:

Warning: Missing argument 1 for replies() in Warning: Missing argument 1 for replies() in c:\inetpub\wwwroot\mysample\functions\library.php on line 321
Error with SELECT count(postID) AS rowcount FROM comments WHERE postID=

the code in line 321 is this

function replies($postID)

now, where could be the problematic area??

thanks

[markl999]

It's probably coming from:
replies(floor($row[2]))

After the while line echo out the value of $row[2], e.g
while ($row = mysql_fetch_array($result, MYSQL_NUM))
{
//puta
echo 'row2: '.$row[2];

It's probably not set/empty.

[heigh]

thanks....i tried but it only shows the topicID # of the specific thread...not the reply

[markl999]

Well that's the only place in the code you posted that replies() is called and as you're getting:
SELECT count(postID) AS rowcount FROM comments WHERE postID=
it means the passed in $postID was empty, which means floor($row[2]) was empty.
Unless the error is coming from somewhere outside of the code you posted.

[heigh]

i just called the admin function to the viewing page and that's it.....

[markl999]

Hmm, the errors on line 321 but you only posted 123 lines. Sure there's no more?

[heigh]

the other codes are also functions, i believe they have no relation to the two i posted

[markl999]

Then it must be replies(floor($row[2])) as that's the only place replies() is called.
What does echo floor($row[2]); output?

[heigh]

i modified the (floor($row[2])) part, removed the floor()....yes, that's the only place the replies() was called....it outputs the number of replies of a certain thread/message, but that error keeps on appearing.....with or without the floor()...

[markl999]

If you have PHP 4.3.0 or above then you could try this:

//replies function
function replies($postID)
{
    if(empty($postID)) {
        echo '<pre>';
        var_dump(debug_backtrace());
        echo '</pre>';
    }
    //rest of function here
} 

and post the output. It should tell you the line number where the erronous call was made.

[heigh]

no mysql query??

[markl999]

Yeah, that's covered by the line:
//rest of function here


I just added a bit to the top of the function, the rest of it still goes in there as was.

[heigh]

did that, but the error message is still there.....and it prints something like this

array(2) {
[0]=>
array(4) {
["file"]=>
string(49) "c:\inetpub\wwwroot\mysample\reportbodycontent.php"
["line"]=>
int(24)
["function"]=>
string(7) "replies"
["args"]=>
array(0) {
}
}
[1]=>
array(4) {
["file"]=>
string(38) "c:\inetpub\wwwroot\mysample\report.php"
["line"]=>
int(58)
["args"]=>
array(1) {
[0]=>
string(49) "c:\inetpub\wwwroot\mysample\reportbodycontent.php"
}
["function"]=>
string(7) "include"
}
}

[markl999]

Yeah, it wasn't supposed to fix it, just debug it

What's line 24 of c:\inetpub\wwwroot\mysample\reportbodycontent.php?

[heigh]

whoaah!!!thanks a lot.....i got it now.....i forgot to remove the replies() from line 24 of reportbodycontent.php.....did that while experimenting.....your great man....it really worked great...thanks again man....

[markl999]

No problem