Problem with simple if statement

[jimday1982]

I'm using this if statement:

            if ($carrier = "UPS") {
             $emailbody .= "Tracking link: http://wwwapps.ups.com/etracking/tracking.cgi?TypeOfInquiryNumber=T&InquiryNumber1=" . $number . "\n\n";
             }
             
             elseif ($carrier = "FED-EX") {
             $emailbody .= "Tracking link: http://www.fedex.com/cgi-bin/tracking?action=track&language=english&cntry_code=us&initial=x&mps=y&tracknumbers=" . $number . "\n\n";
             }
             
             elseif ($carrier = "USPS") {
             $emailbody .= "Tracking link:  http://www.usps.com/shipping/trackandconfirm.htm\n\n";
             }
             
             else{
             $nolink = "1";
             $emailbody .= "\n\n";
             }
             //$emailbody .= "Order ID: " . $order_id . "\n\n";
             if ($nolink = "1"){
             }
             else{
             $emailbody .= "To track your package, please click the link above.\n"; 
             } 

and all of the records in my database have nothing in the "carrier" field. I don't understand that when my code sends the emails (furhter down in the code), they all include the UPS link. I have it set in my code to only include that link if the "carrier" field contains "UPS"...am I missing something here? Thanks for your help.

[jaswinder_rana]

you said
if ($carrier = "UPS")
but it should be
if ($carrier == "UPS")

two == sign everywhere even for "Fed-Ex" or something else

== means check if they are ewual and
= means make them equal and this always gonna be true RIGHT

[jimday1982]

Crap, nevermind...I needed "==" in my if statements.

Thanks for the quick reply though.

[MikeBigg]

It is because you need to use the double equals ( == ) for comparisons in PHP.

In the if statement you are setting $carrier equal to 'UPS ' which then returns true and so the first clause is executed.

Mike

[swdev]

Use == for testing, not =

Better would be

  if ('UPS' == $carrier)
  {
  }
  else if ('FED-EX' == $carrier)
  {
  }
  ... 

Better than that, IMHO

  switch ($carrier)
  {
    case 'UPS':
       // do ups stuff
        break;
    case 'FED-EX':
       // do FedEx stuff
        break;
    default:
       // do default stuff
        break;
  }