Newbie in oop of php,Anyone plz help me!

[ujjwal]

Hi everybody,
I am very new in object oriented in php.
plz solve me out.
I am creating a class which saved class.Demo.php
<? php
public class Demo {
public $_name;
public function sayhello() {
print "Hello ($this->getname()}!";
}
public function getname() {
return $this->_name;
}
public function setname($name) {
if(!is_string($name)||strlen($name)==0) {
throw new Exception("Invalid name value");
}
$this->_name = $name;
}
}
?>then create a file which saved as testdemo.php
<?php
require_once('class.Demo.php');
$obj = new Demo();
$obj->setname('ujjwal');
$obj->sayhallo();
$obj->setname(37);
?>If i open testdemo.php then see an error i.e
Parse error: parse error, unexpected T_STRING in d:\inetpub\wwwroot\class.Demo.php on line 2

Fatal error: Cannot instantiate non-existent class: demo in d:\inetpub\wwwroot\testdemo.php on line 3
Plz can u solved it. advanced thanks for u'r help.

[vinyl-junkie]

You defined your function with the name sayhello, then called it with the name sayhallo.

[ujjwal]

You defined your function with the name sayhello, then called it with the same sayhallo.

Thank you. ihave overlooked it.but after this changing the error is stil present.and u noticed that the line of errors are 2,3 of class and test file respectively.

[Daimaju]

use class Demo instead of public class Demo, php is not java

[trib4lmaniac]

You can use the public keyword in php5, but I don't think you can before a class. After all, why have a class if you can't access it?

[ujjwal]

use class Demo instead of public class Demo, php is not java

I have done it but the error remains same

[ujjwal]

You can use the public keyword in php5, but I don't think you can before a class. After all, why have a class if you can't access it?

I can't understand where is my wrong what type of this error?
can u pointed this thing?

[trib4lmaniac]

Don't double post, edit the previous one

What version of php are you using?

[ujjwal]

Don't double post, edit the previous one

What version of php are you using?

php4
How can i remove this error?

[trib4lmaniac]

Try taking out all occurences of the keyword "public".

Look on these pages for class differences between php4 and 5...
http://uk.php.net/manual/en/language.oop.php
http://uk.php.net/manual/en/language.oop5.php

[Kilroy]

Try taking out all occurences of the keyword "public".

Look on these pages for class differences between php4 and 5...
http://uk.php.net/manual/en/language.oop.php
http://uk.php.net/manual/en/language.oop5.php

That shouldn't be necessary - public is a fine keyword for variables and methods in PHP5... try this instead:

<?php
class Demo {

  public $_name;

  public function sayhello() 
  {
    print "Hello {$this->getname()}!";
  }

  public function getname()
  {
    return $this->_name;
  }

  public function setname($name)
  {
    if(!is_string($name) || strlen($name) == 0) {
      throw new Exception("Invalid name value");
    }

    this->_name = $name;
  }

}
?>

Also, your method sayhello had a parenthese => ( somewhere where it had to be a brace => {

----------------------------------------------

Oh - you are using PHP4! Well, if you are, use my code above and remove all keywords "public" and replace:

public $_name; 

with

var $_name; 

Also, you will have to take out the exception part. Replace this:

throw new Exception("Invalid name value"); 

with this:

echo "Invalid name value!"; 

I hope that helped!

[ujjwal]

Now i am using php 5.0.2.and the error reducing to
Parse error: syntax error, unexpected T_CLASS in d:\Inetpub\wwwroot\class.Demo.php on line 2
where corresponding my class.demo.php file is
<? php
class Demo {
private $_name;
public function sayhello() {
print "Hello ($this->getname()}!";
}
public function getname() {
return $this->_name;
}
public function setname($name) {
if(!is_string($name) || strlen($name) == 0 ) {
echo "Invalid name value!";

}
$this->_name = $name;
}
}
?>Plz solve it.I am bitting up.

[vinyl-junkie]

If I might make a suggestion, you need to read something like Chapter 2 in SitePoint's PHP Anthology 1, where it discusses the basics of object oriented programming.

You've violated all kinds of rules for OOP in your code. For example, you're not really returning anything of value, just the original name you passed to your object in the first place. You should also separate presentation from business rules.

Here is a cleaned up version of your code, which is what I think you're really trying to do:

<? php
class Demo {
private $_name;

public function setname($name) {
if(!is_string($name) || strlen($name) == 0 ) {
$return_message = "Invalid name value!"; 
}
$this->_name = $name;
}

public function sayhello() {
$return_message = "Hello".$this->getname."!";
$this->getname();
}

public function getname() {
return $return_message;
}

}

?>

[Kilroy]

I think getname() should only echo the person's name and not something like "Hello <name>", because it would then get more than just the name. However, this may be only how I see it

[vinyl-junkie]

I think getname() should only echo the person's name and not something like "Hello <name>", because it would then get more than just the name. However, this may be only how I see it

Well, if you're going to use a method name like getname(), I guess that would imply that's what you want from your object.

What I posted was only a suggestion anyway (as well as cleaning up the coding errors). I think what this person is really trying to do is just get a feel for how OOP works for PHP.

[Infizi]

heres yalls problem, you have all gone wayyy past the error.

Line 2,

look at line two. Hes told PHP its pubic, but forgot to desfine the variable.
Also, on OO, your using an object, so the functions in theroy only apply to that object, so going furthut, why would you call just $hello, if you have more than one clas open, your stuck. you would call $class->hello(), os i have also removed the public functions.
Have you tried

NB public var $var;

<? php
class Demo {
public var $_name;
function sayhello() {
print "Hello ($this->getname()}!";
}
function getname() {
return $this->_name;
}
function setname($name) {
if(!is_string($name) || strlen($name) == 0 ) {
echo "Invalid name value!"; 

}
$this->_name = $name;
}
}
?>

[j996_adict]

class.Demo.php :

<?php

class Demo {
    
    private $_name;

    public function sayHello() {
        echo 'Hello ('.$this->getname().'}!"';
    }
    
    public function getName() {
        return $this->_name;
    }
    
    public function setName($name='') {
        
        if(!is_string($name) || strlen($name) == 0) {
            echo "Invalid name value!";
        }
        else {
            $this->_name = $name;
        }
    }
}
?>

test.php :

<?php
require_once('class.Demo.php');

$dem = new Demo();

$dem->setName('j996');

$dem->sayHello();

$dem->setName();

?>

Tested on PHP5 and working fine!

[Kilroy]

Glad you worked it out!

vinyl-junkie, I understand that person just wants to learn OOP I was merely suggesting that a more appropriate name could be chosen for the method.

[Infizi]

i still dont see the point of having public function?

If you create a class then you can call it from where ever its been defined using $class->function(args)!!!

So why, just why>?

[Daimaju]

in php5 there are also private/protected functions/vars that can only be accessed inside the class (private) or a class extending it (protected)

with these two keywords public makes sense, without them not

[Infizi]

ok, i see your point, but why make it public?

Do you mean public as in you can call $class->publicfunction(), as appose to an error if you tryed $class->privatefunction();

in php5 there are also private/protected functions/vars that can only be accessed inside the class (private) or a class extending it (protected)

with these two keywords public makes sense, without them not

[Kilroy]

Infizi, that is indeed the reason. Private methods are, so to say, functions that can only be called by other methods in the particular class