Logging ip's

[Beckwith]

I have a code that will log the ip of the user and display it, however it's not logging it. It doesn't say there's anything wrong with the code, and doesn't give me any errors, just when I type select * from ips; it says empty set. Here's the code:

<?php
$ip = $_SERVER['REMOTE_ADDR'];
$sql = "INSERT INTO ips SET
       ip='$ip',
       view_date='CURDATE()',
       view_time='CURTIME()'";
if ($sql) {
  echo('IP Logged: ' . $ip . '');
} else {
  die('Error logging your ip:' . $ip . '');
}
?>

and here's my sql code (MySQL):

CREATE TABLE ips (
ID INT NOT NULL AUTO_INCREMENT PRIMARY KEY,
ip VARCHAR(15) NOT NULL,
view_date DATE NOT NULL,
view_time TIME NOT NULL
);
Query OK, 0 rows affected (0.01 sec)

I don't see anything wrong with my syntax or sql, any of you see anything wrong?

[Young Twig]

You need to use mysql_query(). Also, are you connecting to the db?

<?php
$ip = $_SERVER['REMOTE_ADDR'];
$sql = mysql_query("INSERT INTO ips SET
       ip='$ip',
       view_date='CURDATE()',
       view_time='CURTIME()'");
if ($sql) {
  echo('IP Logged: ' . $ip . '');
} else {
  die('Error logging your ip:' . $ip . '');
}
?>

[Beckwith]

Thanks, worked! Oh and one other thing though for other people coming with the same problem,

<?php 
$ip = $_SERVER['REMOTE_ADDR']; 
$sql = mysql_query("INSERT INTO ips SET 
       ip='$ip', 
       view_date='CURDATE()', 
       view_time='CURTIME()'"); 
if ($sql) { 
  echo('IP Logged: ' . $ip . ''); 
} else { 
  die('Error logging your ip:' . $ip . ''); 
} 
?>

view_date='CURDATE()', needs to be view_date=CURDATE(), without the single quotes, and same for CURTIME().

Thanks a lot!

[i_like_php]

ok so could you show the updated sql and code so i can use this for testing as well .

[newfiewebguru]

<?php
$ip = $_SERVER['REMOTE_ADDR'];
$sql = mysql_query("INSERT INTO ips SET
       ip='$ip',
       view_date='CURDATE()',
       view_time='CURTIME()'");
if ($sql) {
  echo('IP Logged: ' . $ip . '');
} else {
  die('Error logging your ip:' . $ip . '');
}
?>

Should actually be the following, if you want to input curtime() and curdate() dirrectly into the database:

<?php
$ip = $_SERVER['REMOTE_ADDR'];
$sql = mysql_query("INSERT INTO ips SET
       ip='$ip',
       view_date='".CURDATE()"',
       view_time='".CURTIME()."'");
if ($sql) {
  echo('IP Logged: ' . $ip . '');
} else {
  die('Error logging your ip:' . $ip . '');
}
?>

It may work the way you posted, but this way is safer.

[Young Twig]

<?php
$ip = $_SERVER['REMOTE_ADDR'];
$sql = mysql_query("INSERT INTO ips SET
       ip='$ip',
       view_date='".CURDATE()"',
       view_time='".CURTIME()."'");
if ($sql) {
  echo('IP Logged: ' . $ip . '');
} else {
  die('Error logging your ip:' . $ip . '');
}
?>

It may work the way you posted, but this way is safer.

Should actually be: (Missed a period)

<?php
$ip = $_SERVER['REMOTE_ADDR'];
$sql = mysql_query("INSERT INTO ips SET
       ip='$ip',
       view_date='".CURDATE()."',
       view_time='".CURTIME()."'");
if ($sql) {
  echo('IP Logged: ' . $ip . '');
} else {
  die('Error logging your ip:' . $ip . '');
}
?>

How is this method more safe?

[SniperX]

Incidentally, you may find this IP gathering function a little more reliable.

function realIp() {
    $ip=FALSE;
    if(!empty($_SERVER["HTTP_CLIENT_IP"])) $ip=$_SERVER["HTTP_CLIENT_IP"];

    if(!empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
        $ips=explode(", ", $_SERVER['HTTP_X_FORWARDED_FOR']);
        if ($ip) { array_unshift($ips, $ip); $ip = FALSE; }
        for ($i = 0; $i < count($ips); $i++) {
            if (!eregi ("^(10|172\.16|192\.168)\.", $ips[$i])) {
                $ip = $ips[$i];
                break;
            }
        }
    }
    return ($ip ? $ip : $_SERVER['REMOTE_ADDR']);
} 

This function will get the real IP Address, as opposed to the IP address of the transparent proxy that many cable companies force their customers to route through.

How we currently use it:

<div class="box_general">
    <p>To help us resolve the issue that you report, the following information will be sent to the Studio-X Admin team:</p>
<!-- Advise User of Information Being Sent -->
<div class="callout_box">
    <?
        $ip = realip();
        $browser = $_SERVER['HTTP_USER_AGENT'];
        if (!$cmd) { $callout_text = "<p>IP Address: $ip</p><p>Browser: $browser</p><p>Member Name: $member_name</p>"; }
        else { $callout_text = $redirect_message; }
        echo $callout_text;
    ?>
</div>.....

I can't take credit for the function, it's just something that I picked up from somewhere a while back and now can't live without.

[Mower]

thanks that ip function rocks