Form Validation

[Lewis]

I am trying to create a simple validation class for my registration form. I am having great difficulty with my logic (among some things). I can't get to "count" the variable to do as I want. I am basically using the function countErrors () to check and see if there were any errors incurred. Thanks for any help you can offer... I know it's a mess.

class ValidateReg {

    var $db;
    var $errors;
    var $count;
    
    function ValidateReg (&$db) {
        $this->db=& $db;
        $this->errors= " ";
        $this->count= 0;
        }
    

    function username ($username = " ") {
         if     ( $username == " " )
            return false;
        else
            return true;
    }
    
    function uniquename ($username = " ") {
        $sql = "SELECT * FROM
                   ".person."
                WHERE
                   ".username."='".$username."'";
        $result = $this->db->query($sql);

        if     ( $result->size() > 0 ) 
            return false;
        else
            return true; 
    }
    
    function displayErrors () {
        if ( !$this->username () ) {
            $this->errors = '<strong>Username required!</strong><br />';
            $this->count++;
            }
        if ( !$this->uniquename () ) {
            $this->errors .= '<strong>Username already registered!</strong>';
            $this->count++;
            }
            echo $this->errors;
    }            
    
    function countErrors () {
        if ($this->count > 0) 
            return false;
        else
            return true;
        }
} 

[sonic_2k_uk]

hi

i think the problem is this...

    function displayErrors () { 
        if ( !$this->username () ) { 
            $this->errors = '<strong>Username required!</strong><br />'; 
            $this->count++; 
            } 
        if ( !$this->uniquename () ) { 
            $this->errors .= '<strong>Username already registered!</strong>'; 
            $this->count++; 
            } 
            echo $this->errors; 
    }             
     
    function countErrors () { 
        if ($this->count > 0) 
            return false; 
        else 
            return true; 
        } 

when you say $this->count++; in the function displayErrors, your basically saying... displayErrors->count++, and then when you call it in countErrors your trying to call countErrors->count, which isnt assigned.

hope that helps

Andy Buron

[Lewis]

Thank you for the click reply. Sounds good, but I'm not sure how I would fix it :-)

In another post, I think I am studying much better logic:
http://www.sitepoint.com/forums/show...05&postcount=8

So I'm going to rework the class.

[Lewis]

Can't figure this one out:
Fatal error: Call to a member function on a non-object in /home/virtual/site299/fst/var/www/html/Validate.php on line 27

class Validation {

    var $db;
    var $Errors;
    
    function ValidateReg (&$db) {
        $this->db=& $db;
    }
    
      function AddError($description) {
          $this->Errors[] = $description;
       }
    
    function username ($username = " ") {
         if     ( $username == " " ) {
            $this->addError('Username required!');
        } else {
            $sql = "SELECT * FROM
                   ".person."
                WHERE
                   ".username."='".$username."'";
            $result = $this->db->query($sql);

            if     ( $result->size() > 0 ) 
                $this->addError('Username already registered!');
        }
    }
    
    function IsError() {
          return (is_array($this->Errors) && count($this->Errors) > 0);
       }
    
    function GetErrors() {
          return $this->Errors;
       }
} 

[seratonin]

Can't figure this one out:
Fatal error: Call to a member function on a non-object in /home/virtual/site299/fst/var/www/html/Validate.php on line 27

class Validation {

    var $db;
    var $Errors;
    
    function ValidateReg (&$db) {
        $this->db=& $db;
    }
    
      function AddError($description) {
          $this->Errors[] = $description;
       }
    
    function username ($username = " ") {
         if     ( $username == " " ) {
            $this->addError('Username required!');
        } else {
            $sql = "SELECT * FROM
                   ".person."
                WHERE
                   ".username."='".$username."'";
            $result = $this->db->query($sql);

            if     ( $result->size() > 0 ) 
                $this->addError('Username already registered!');
        }
    }
    
    function IsError() {
          return (is_array($this->Errors) && count($this->Errors) > 0);
       }
    
    function GetErrors() {
          return $this->Errors;
       }
} 

It sounds to me like the database query is failing and you are not getting a result back. I assume you are using PEAR for your abstraction layer. If so, try doing something like this:

$result =& $this->db->query($sql);
if (DB::isError($result)) {
    die($result->getMessage());
} 

JT

[Lewis]

Sorry, I'm using MySQL.php from Harry's A1.

[Lewis]

Stupid me! I changed the name of the class but forgot to change the constructor name as well! Sorry to waste anyone's time but I had spent two days looking at this!

[lazy_yogi]

lol ... yeh **** happens