login form question

[luckyirish]

I made a test login form in php, but it has a problem:
When i enter the correct username and pass, i get the following message:

Warning: Cannot modify header information - headers already sent by (output started at c:\program files\apache group\apache\htdocs\home.php:10) in c:\program files\apache group\apache\htdocs\home.php on line 32

Warning: Cannot modify header information - headers already sent by (output started at c:\program files\apache group\apache\htdocs\home.php:10) in c:\program files\apache group\apache\htdocs\home.php on line 33

Warning: Cannot modify header information - headers already sent by (output started at c:\program files\apache group\apache\htdocs\home.php:10) in c:\program files\apache group\apache\htdocs\home.php on line 34






(i am hosting the script locally on an apache server)

Here is the script:

<?php
// valid login credentials
$username = 'sean';
$password = 'password';
// grab current time
$time=time();

// handle the logout event
if ($logout == true) {
setcookie ("user", md5($_POST[user]), $time-3200);
setcookie ("pass", md5($_POST[pass]), $time-3200);
header("Location: home.php");
}

// handle validation event
if ($_POST[user] && $_POST[pass]) {
if ($_POST[user]==$username && $_POST[pass]==$password) {
setcookie ("user", md5($_POST[user]), $time+3200);
setcookie ("pass", md5($_POST[pass]), $time+3200);
header("Location: home.php");
} else { $login_error= true; }
}

// handle login event, both successful and erroneous, or show login screen
if ($login_error == true) { ?>
<table align=center style="font-family:arial; font-size:12; border:1 solid #000000;">
<tr><td align=center bgcolor=#123dd4>LOGIN ERROR</td></tr>
<tr><td align=center><b>Invalid Username and/or Password</b><br><br><a href=home.php>Back</a></td></tr>
</table>
<?
} elseif ($_COOKIE[user] == md5($username) && $_COOKIE[pass] == md5($password)) { ?>
<table align=center style="font-family:arial; font-size:12; border:1 solid #000000;">
<tr><td align=center bgcolor=#123dd4>SECURE AREA</td></tr>
<tr><td align=right><a href=home.php?logout=true>Logout</a></td></tr>
<tr><td>You have successfully logged in.<br><br>
Encrypted Username: <b><?= $_COOKIE[user] ?></b><br>
Encrypted Password: <b><?= $_COOKIE[pass] ?></b><br>
</td></tr>
</table>
<?
} else {
?>
<form action=home.php method=post>
<table align=center class="table1">
<tr><td colspan=2 align=center bgcolor=#123dd4>LOGIN</td></tr>
<tr><td align=right>Username: </td><td><input type=text name=user size=15></td></tr>
<tr><td align=right>Password: </td><td><input type=password name=pass size=15></td></tr>
<tr><td align=center colspan=2><input type=submit value=Login></td></tr>
</table>
</form>
<?
}

someone please help

[Wbmstr84]

Ensure that you havent sent any html or white space to the browser before you redirect.

[luckyirish]

im not sure what u mean

[luckyirish]

ok n/m i got the login form to work but now when i try to logout it just refreshes the page and keeps me logged in
wuts up with that¿

[luckyirish]

help me

[Wbmstr84]

There are a few different ways to do this but try adding the following to the logout action.

$_COOKIE['user']='';
$_COOKIE['pass']='';

[amrknt]

I think this is b'coz of line

header("Location: home.php"); 

I'm also facing these type of problems on my WNIDOWS based machine. However when I run my codes from web server hosted on LINUX, all these codes run smoothly without having any problem.

What's the reason behind it I don't know, but willing to know if anyone tell me.

Thanks

[wim]

very simple - you need to add an 'exit' statement after each header statement.

[luckyirish]

im very new to php and im not sure what u mean by an exit statement- could you chow me an example?

[mcahill]

This should do it. You could also use an output buffer...

// handle validation event 
if ($_POST[user] && $_POST[pass]) { 
if ($_POST[user]==$username && $_POST[pass]==$password) { 
setcookie ("user", md5($_POST[user]), $time+3200); 
setcookie ("pass", md5($_POST[pass]), $time+3200); 
header("Location: home.php"); 
exit();
} else { $login_error= true; } 
} 

http://us2.php.net/manual/en/function.exit.php

[luckyirish]

now i get this error message when i try to login:
Parse error: parse error, unexpected T_STRING in c:\program files\apache group\apache\htdocs\login\index.php on line 20

[Wbmstr84]

please post the first 25 lines or so of the index.php page

[luckyirish]

this is the entire inde.php code:

<?php
// valid login credentials 
$username = 'sean'; 
$password = 'password'; 
// grab current time 
$time=time(); 

// handle the logout event 
if ($logout == true) { 
setcookie ("user", md5($_POST[user]), $time-3200); 
setcookie ("pass", md5($_POST[pass]), $time-3200); 
header("Location: index.php"); 
} 

// handle validation event 
if ($_POST[user] && $_POST[pass]) { 
if ($_POST[user]==$username && $_POST[pass]==$password) { 
setcookie ("user", md5($_POST[user]), $time+3200); 
setcookie ("pass", md5($_POST[pass]), $time+3200); x
header("Location: index.php"); 
exit();
} else { $login_error= true; } 
} 

// handle login event, both successful and erroneous, or show login screen 
if ($login_error == true) { ?> 
<table align=center style="font-family:arial; font-size:12; border:1 solid #000000;"> 
<tr><td align=center bgcolor=#123dd4>LOGIN ERROR</td></tr> 
<tr><td align=center><b>Invalid Username and/or Password</b><br><br><a href=index.php>Back</a></td></tr> 
</table> 
<? 
} elseif ($_COOKIE[user] == md5($username) && $_COOKIE[pass] == md5($password)) { ?> 
<table align=center style="font-family:arial; font-size:12; border:1 solid #000000;"> 
<tr><td align=center bgcolor=#123dd4>SECURE AREA</td></tr> 
<tr><td align=right><a href=index.php?logout=true>Logout</a></td></tr> 
<tr><td>You have successfully logged in.<br><br> 
Encrypted Username: <b><?= $_COOKIE[user] ?></b><br> 
Encrypted Password: <b><?= $_COOKIE[pass] ?></b><br> 
</td></tr> 
</table> 
<? 
} else { 
?> 
<form action=index.php method=post> 
<table align=center class="table1"> 
<tr><td colspan=2 align=center bgcolor=#123dd4>LOGIN</td></tr> 
<tr><td align=right>Username: </td><td><input type=text name=user size=15></td></tr> 
<tr><td align=right>Password: </td><td><input type=password name=pass size=15></td></tr> 
<tr><td align=center colspan=2><input type=submit value=Login></td></tr> 
</table> 
</form> 
<? 
}
?>

[Wbmstr84]

whats with the trailing x in the following line

setcookie ("pass", md5($_POST[pass]), $time+3200); x

remove that x

[luckyirish]

thanks for the tip i know longer get the error message but now ive run into the same problem i had before - once i login, i try to puch logout and it doesnt do anything

[luckyirish]

help?¿
anyone?¿

[Wbmstr84]

not sure if it will help but change the logout function to this...

// handle the logout event 
if ($_GET['logout'] == true) { 
setcookie ("user", "", $time-3200); 
setcookie ("pass", "", $time-3200); 
header("Location: index.php"); exit();
} 

[luckyirish]

no man that didnt help but thanx neway

[luckyirish]

alrite i finally got but thanx for your post that really put me in the right direction

[Wbmstr84]

Care to post what the problem was... for others who might be following this thread?

[luckyirish]

well to tell you the truth i dont know all i did was move the file to a new location and it worked??? but i think your code was completely right
thanks again man

[Wbmstr84]

Alrighty Thanks... glad to hear all is well!

[vhogarth]

I'm getting the same header(); error you were getting. You dont know how you fixed it? I'm stuck and staring at this little script with my eyes buggin out trying to figure out whats wrong with it... Any help?

<? 
/* Check User Script */ 
session_start();  // Start Session 

include ('./connect/mysql_connect.php');
include ('./header.inc');

// Conver to simple variables 
$username = $_POST['username']; 
$password = $_POST['password']; 

if((!$username) || (!$password)){ 
    echo "Please enter ALL of the information. <br />"; 
    include 'login_form.html'; 
    include ('./footer.inc');
    exit(); 
} 
else{

// Convert password to md5 hash 


// check if the user info validates the db 
$sql = mysql_query("SELECT * FROM players where username='$username' AND password='$password'") or die(mysql_error());  
$login_check = mysql_num_rows($sql); 

if($login_check > 0){ 
    while($row = mysql_fetch_array($sql)){ 
    foreach( $row AS $key => $val ){ 
        $$key = stripslashes( $val ); 
    } 
        // Register some session variables! 
        session_register('firstName'); 
        $_SESSION['firstName'] = $firstName; 
        session_register('lastName'); 
        $_SESSION['lastName'] = $lastName; 
        session_register('emailAddress'); 
        $_SESSION['emailAddress'] = $emailAddress; 
                
         
                 
        header("Location: roster.php"); 
        exit();
    } 
} else { 
    echo "You could not be logged in! Either the username and password do not match or you have not validated your membership!<br /> 
    Please try again!<br />"; 
    include 'login_form.html'; 
} 
}
include ('./footer.inc');
?>