News Script OOP Question

[GamerZ]

Hi all, just beginning to learn about oop for php. I am currently doing a news script. I would like to ask whether the method below is apporiate.

For Example

    $results = $db_sql->query("SELECT post_date, post_title, category_name, user_name FROM $tableposts INNER JOIN $tablecategory ON $tableposts.post_category = $tablecategory.category_id INNER JOIN $tableusers ON $tableposts.post_userid = $tableusers.user_id LIMIT 5");
    while($results = $db_sql->fetchArray($results)) {
                  $postinfo[$results[post_id]] = new News;
                  $postinfo[$results[post_id]]-> displayTime();
                  $postinfo[$results[post_id]]-> displayDate();
                  $postinfo[$results[post_id]]-> displayAuthor();
                  $postinfo[$results[post_id]]-> displayContent();
    } 

[GamerZ]

Anyone can help pls?

[HarryF]

Some thoughts;

I'm not sure about the way you're using $results['post_id'] (note the quotes!) as the index for the $postinfo array. If think you'd be better off letting $postinfo define it's own index.

Also what are you trying to do here;

                  $postinfo[$results[post_id]]-> displayTime();
                  $postinfo[$results[post_id]]-> displayDate();
                  $postinfo[$results[post_id]]-> displayAuthor();
                  $postinfo[$results[post_id]]-> displayContent(); 

?

Here's how I'd do what you're doing (using procedural code);

     // Does this query really need to be so complex?
     $sql = "SELECT
                 post_date, post_title, category_name, user_name
               FROM
                 $tableposts
               INNER JOIN
                 $tablecategory
               ON
                 $tableposts.post_category = $tablecategory.category_id
               INNER JOIN
                 $tableusers
               ON
                 $tableposts.post_userid = $tableusers.user_id
               LIMIT 5";

     $results = $db_sql->query($sql);

     $postinfo=array(); // Initialize

     // Note "$result =" NOT "$results = "
     while($result = $db_sql->fetchArray($results)) {
           $postinfo[] = new News($result);
     }

     // Output here
     foreach ( $postinfo as $post ) {
          echo ( 'Posted at '.$post->time() );
     } 

Have a read of this and this for some more ideas.

[GamerZ]

thanks for the help =D. The SQL code will join my post, category and user tables together, so that I can get the username and category name. Hehe